ci: separate out a daily-tests workflow #517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were running both the `connect-test` (for checking platform-verifier works against `example.com`) and the `ech-test` (for checking ECH works against cloudflare's test server) as part of normal CI. In practice relying on remote servers as a blocking condition for a pass on a required CI task is crummy. Flakes outside of our control can cause build failures that later resolve themselves. Instead, follow the main rustls repo practice of running a separate CI job on a daily schedule. This makes flakes less onerous while still maintaining the test coverage. The workflow can also be manually invoked in the GitHub UI via the manual dispatch trigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were running both the
connect-test(for checking platform-verifier works againstexample.com) and theech-test(for checking ECH works against cloudflare's test server) as part of normal CI.In practice relying on remote servers as a blocking condition for a pass on a required CI task is crummy. Flakes outside of our control can cause build failures that later resolve themselves.
Instead, follow the main rustls repo practice of running a separate CI job on a daily schedule. This makes flakes less onerous while still maintaining the test coverage. The workflow can also be manually invoked in the GitHub UI via the manual dispatch trigger.
Updates #514