Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Windows ECH test flake #514

Open
cpu opened this issue Dec 23, 2024 · 1 comment
Open

Debug Windows ECH test flake #514

cpu opened this issue Dec 23, 2024 · 1 comment
Assignees

Comments

@cpu
Copy link
Member

cpu commented Dec 23, 2024

The Windows ech test target seems flaky. Roughly half the time it fails with output like:

  research.cloudflare.com.ech.configs.bin
  client[1848]: using the platform verifier for certificate verification.
  client[1848]: using ECH config lists 'research.cloudflare.com.ech.configs.bin'
  client[1848]: no compatible/valid ECH configs found in 'research.cloudflare.com.ech.configs.bin'
  client[1848]: failed to configure ECH with any provided config files

That's pretty odd since we find compatible configs reliably with the Linux and Apple versions of this test. It's not clear if we're putting junk in the .bin file as a result of an issue with ech-fetch, or if there's something wrong on the rustls-ffi/rustls side. More debug output & reproducing it outside of CI are required.

@cpu
Copy link
Member Author

cpu commented Dec 24, 2024

Very odd! I booted into Windows this morning to try and reproduce and: it worked fine. Then I kicked the CI jobs that were failing with this error yesterday and they also passed 🤷 I thought that meant the problem was gone but while preparing #517 it started happening again on that branch.

I'll keep digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant