-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tool to generate event UIDs and update README #67
Conversation
7f80eb8
to
6b294a2
Compare
6b294a2
to
6f2cf5a
Compare
6f2cf5a
to
125e694
Compare
9d54d3d
to
1449574
Compare
Why not just suggest using |
Well, that's the idea here, is to spare dependencies so we don't need to ask people to install anything else. This also means that we produce these UIDs in the consistent and exactly desired way. This too isn't particularly complicated, and only depends on Most of the small number of lines of code here is just settings things up for the |
I can't speak for many operating systems, but in Debian a UUID generator is marked as "required", in Fedora too (afaik). I think we can safely assume that it is installed by default everywhere? What's the dependency chain of Anyway, just my .2 cents to avoid bloat. |
Rust and the |
Can you add a check/fmt/test for this utility in the CI? |
7638ef9
to
18f9f35
Compare
According to the iCalendar (IETF) RFC 5545, the UID for each event must be "globally unique". In this context, that means that the identifier must not collide with any other identifier for any other calendar event across all calendars, ever. The way we were suggesting that people generate these, by calling out to `date`, unfortunately falls a bit short of being able to assure this. Let's instead add a small tool runnable with `cargo xtask` to generate sufficiently-long randomly-generated identifiers to make it easy for people to do the right thing here for new events.
Let's add tests to ensure that the code of our `cargo xtask` tool is formatted correctly and to ensure that it builds and runs correctly. We mirrored the details of the current CI configuration of `calendar-generator`.
18f9f35
to
568990c
Compare
According to the iCalendar (IETF) RFC 5545, the UID for each event must be "globally unique". In this context, that means that the identifier must not collide with any other identifier for any other calendar event across all calendars, ever.
The way we were suggesting that people generate these, by calling out to
date
, unfortunately falls a bit short of being able to assure this.Let's instead add a small tool to generate sufficiently-long randomly-generated identifiers to make it easy for people to do the right thing here for new events.
Merge this one after:
calendar
repo containingxtask
in CI calendar-generation#15MIT OR Apache-2.0
#66cc @davidtwco