Skip to content

Add no_std #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2021
Merged

Add no_std #51

merged 3 commits into from
May 5, 2021

Conversation

RCasatta
Copy link
Contributor

@RCasatta RCasatta commented Apr 11, 2021

It's different from #46 because MSRV with std is still 1.29, while for no_std the MSRV is 1.36 because it uses alloc.

Includes a test in CI building a no_std embedded program (the test requires nightly because of the allocator used). The embedded test is not run (only built) because there are issues with emulating arm on github action env.

@RCasatta RCasatta force-pushed the no-std branch 2 times, most recently from ecc59f2 to 3396f53 Compare April 13, 2021 13:51
@RCasatta
Copy link
Contributor Author

RCasatta commented Apr 13, 2021

The last force-push reduced the files needed for the embedded CI test as suggested in rust-bitcoin/bitcoin_hashes#120 (comment)

@RCasatta RCasatta marked this pull request as draft April 14, 2021 21:55
@RCasatta
Copy link
Contributor Author

the latest push actually execute (not just build) the embedded process in CI

@RCasatta RCasatta marked this pull request as ready for review April 15, 2021 09:44
Copy link

@devrandom devrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested as part of my upcoming no_std PR for rust-bitcoin on both 1.29 and stable.

@RCasatta
Copy link
Contributor Author

RCasatta commented May 5, 2021

Hi devrandom, there is a relevant discussion on rust-bitcoin/bitcoin_hashes#120 about how to implement no_std on rust-bitcoin, in particular for handling io::Read and io::Write. I am working on the PR on bitcoin_hashes

Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9921ca8

Thank you for pushing no_std forward, I hope we'll be able to build HW wallets one day using rust-bitcoin 😃

Copy link
Member

@clarkmoody clarkmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this work 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants