-
Notifications
You must be signed in to change notification settings - Fork 59
Add no_std #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std #51
Conversation
ecc59f2
to
3396f53
Compare
The last force-push reduced the files needed for the embedded CI test as suggested in rust-bitcoin/bitcoin_hashes#120 (comment) |
the latest push actually execute (not just build) the embedded process in CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Tested as part of my upcoming no_std PR for rust-bitcoin on both 1.29 and stable.
Hi devrandom, there is a relevant discussion on rust-bitcoin/bitcoin_hashes#120 about how to implement no_std on rust-bitcoin, in particular for handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 9921ca8
Thank you for pushing no_std
forward, I hope we'll be able to build HW wallets one day using rust-bitcoin 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this work 🎉
It's different from #46 because MSRV with std is still 1.29, while for no_std the MSRV is 1.36 because it uses
alloc
.Includes a test in CI building a no_std embedded program (the test requires nightly because of the allocator used).
The embedded test is not run (only built) because there are issues with emulating arm on github action env.