Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop: Move open URLs mode from launch options to preferences #18233

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

desktop: Move open URLs mode from launch options to preferences #18233

wants to merge 9 commits into from

Commits on Oct 10, 2024

  1. desktop: Move open_url_mode check to the DesktopNavigatorInterface 

    This allows for greater control over opening URLs on desktop, e.g.
makes it possible to change the mode in runtime without reinstantiating
everything.
    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3711f03 View commit details
    Browse the repository at this point in the history

  2. desktop: Add OpenUrlMode to cli & make Confirm the default 

    OpenUrlModePreference is strictly related to the desktop, which
decouples it from the core in this regard.

Additionally this patch makes Confirm the default, as it prepares it
to be added to Ruffle preferences.
    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e6f2984 View commit details
    Browse the repository at this point in the history

  3. desktop: Add open_url_mode config value to preferences 

    This value controls how links are opened.
    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a8f1bf0 View commit details
    Browse the repository at this point in the history

  4. desktop: Add preferences GUI for open URL mode

    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9f52676 View commit details
    Browse the repository at this point in the history

  5. desktop: Use open URL mode from preferences in DesktopUiBackend

    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b30183d View commit details
    Browse the repository at this point in the history

  6. desktop: Use open URL mode from preferences in DesktopNavigatorInterface

    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bd3fc99 View commit details
    Browse the repository at this point in the history

  7. desktop: Remove open URL mode from the open dialog

    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cbc4aab View commit details
    Browse the repository at this point in the history

  8. desktop: Remove open URL mode from LaunchOptions

    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    308c91c View commit details
    Browse the repository at this point in the history

  9. core: Move OpenURLMode from core to web 

    After changes in desktop, this is the only place where it is used.
This additionally renames it to OpenUrlMode.
    @kjarosh
    kjarosh committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7a60229 View commit details
    Browse the repository at this point in the history