desktop: Move open URLs mode from launch options to preferences #18233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for greater control over opening URLs on desktop, e.g. makes it possible to change the mode in runtime without reinstantiating everything.
OpenUrlModePreference is strictly related to the desktop, which decouples it from the core in this regard. Additionally this patch makes Confirm the default, as it prepares it to be added to Ruffle preferences.
This value controls how links are opened.
After changes in desktop, this is the only place where it is used. This additionally renames it to OpenUrlMode.
kjarosh
added
A-desktop
I assume you noted this due to the Android app - thanks for the heads-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves open links behavior preference from launch options (which was settable before running each SWF) to the preferences (which is settable at any point in time and is persistent).
Additionally, this PR changes the default to "confirm". Users who don't want the confirmation popup to be displayed all the time can disable it, and others will have an additional layer of security on by default.
Opening links without confirmation is unsafe because:
It shares your IP address and other information.
It might be used to leak sensitive information in the URL.
By having the confirmation dialog on by default, users will have a chance to check if the link is safe before opening it.
Fixes #17432.
CC @n0samu
@torokati44 This PR changes a bit the frontend utils API which gives more control to the implementations over how links are opened, but requires adding a simple check by them to preserve the same behavior as before.