Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated ingress template and values to work with GKE http load balancer #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated ingress template and values to work with GKE http load balancer #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.0
version: 0.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change to existing functionality and defaults, so it's more than a patch version bump.


# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
Expand Down
16 changes: 5 additions & 11 deletions templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,9 @@ spec:
- {{ .Values.backend.ingress.hostname | quote }}
secretName: {{ .Values.backend.ingress.secretName | default (printf "%s-tls" (include "rudderstack.fullname" .)) }}
{{- end }}
rules:
- host: {{ .Values.backend.ingress.hostname }}
http:
paths:
- path: /
pathType: Prefix
backend:
service:
name: {{ include "rudderstack.fullname" . }}
port:
number: {{ .Values.backend.service.port }}
defaultBackend:
service:
name: {{ include "rudderstack.fullname" . }}
port:
number: {{ .Values.backend.service.port }}
{{- end -}}
10 changes: 6 additions & 4 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,22 @@ backend:
pullPolicy: Always
controlPlaneJSON: false
ingress:
enabled: false
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think defaulting to a GKE specific ingress enabled is the right choice here, although i agree that it should be supported.

tls: false
annotations: {}
annotations:
kubernetes.io/ingress.global-static-ip-name: <staticIP>
hostname: "rudderstack.local"
# optional override for tls secret name
# secretName: rudderstack-tls
service:
annotations:
cloud.google.com/neg: '{"ingress": false}'
## Refer https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer for more annotations
service.beta.kubernetes.io/aws-load-balancer-backend-protocol: http
# service.beta.kubernetes.io/aws-load-balancer-backend-protocol: http
## For enabling https on aws,
## uncomment below line with acm managed certificate arn and change port value below to 443
# service.beta.kubernetes.io/aws-load-balancer-ssl-cert: arn:aws:acm:us-east-1:123456789012:certificate/12345678-1234-1234-1234-123456789012
type: LoadBalancer
type: NodePort
port: 80
targetPort: 8080
resources:
Expand Down