updated ingress template and values to work with GKE http load balancer #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdashrad
suggested changes
Jul 6, 2021
| @@ -14,7 +14,7 @@ type: application | |||
|
|
|||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| version: 0.2.0 | |||
| version: 0.2.1 | |||
There was a problem hiding this comment.
this is a breaking change to existing functionality and defaults, so it's more than a patch version bump.
| @@ -30,20 +30,22 @@ backend: | |||
| pullPolicy: Always | |||
| controlPlaneJSON: false | |||
| ingress: | |||
| enabled: false | |||
| enabled: true | |||
There was a problem hiding this comment.
i don't think defaulting to a GKE specific ingress enabled is the right choice here, although i agree that it should be supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
These changes to the helm chart were needed to get it working for us on GKE.
This PR changes the service from type
LoadBalancertoNodePortand enables the kubernetes Ingress. It also specifies the correct google annotations to use a reserved static IP and prevent the ingress from creating an NEG (Network Endpoint Group). This will cause google to create an "External HTTP load balancer" instead of using TCP. You can then optionally connect an https-target-proxy, forwarding rule on 443 and a google managed cert to support SSL/TLS.Type of change
Related issues
Checklists
Development
Code review