Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.rb required transitive.rb, so it can be found. #229

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update node.rb required transitive.rb, so it can be found. #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c0b1862
Update node.rb required transitive.rb, so it can be found.
Beagle123 Jan 7, 2025
45613f3
Update document.rb remove require transitive
Beagle123 Jan 10, 2025
d4e3396
Update document.rb
Beagle123 Jan 10, 2025
a0175e0
Merge pull request #1 from Beagle123/Beagle123-patch-1
Beagle123 Jan 10, 2025
2a4d0ec
Update node.rb
Beagle123 Jan 10, 2025
e550d13
Update element.rb
Beagle123 Jan 10, 2025
f441d66
Merge pull request #2 from Beagle123/Beagle123-patch-1
Beagle123 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rexml/document.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def write(*arguments)
end
formatter = if indent > -1
if transitive
require_relative "formatters/transitive"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this empty line.

REXML::Formatters::Transitive.new( indent, ie_hack )
else
REXML::Formatters::Pretty.new( indent, ie_hack )
Expand Down
2 changes: 1 addition & 1 deletion lib/rexml/element.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1505,7 +1505,7 @@ def write(output=$stdout, indent=-1, transitive=false, ie_hack=false)
Kernel.warn("#{self.class.name}.write is deprecated. See REXML::Formatters", uplevel: 1)
formatter = if indent > -1
if transitive
require_relative "formatters/transitive"
require_relative "formatters/transitive"
Copy link
Contributor

@naitoh naitoh Jan 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This position is lazy require.
Please move this line at the beginning position of this file so that it is non-lazy require.

See:

rexml/lib/rexml/element.rb

Lines 1 to 8 in b70388c

# frozen_string_literal: false
require_relative "parent"
require_relative "namespace"
require_relative "attribute"
require_relative "cdata"
require_relative "xpath"
require_relative "parseexception"

REXML::Formatters::Transitive.new( indent, ie_hack )
else
REXML::Formatters::Pretty.new( indent, ie_hack )
Expand Down