Update node.rb required transitive.rb, so it can be found.

[Beagle123]

I recently tried to use REXML::Formatters::Transitive, and its not included in REXML.

[naitoh]

Thank you for this PR.

@kou

https://docs.ruby-lang.org/ja/latest/class/REXML=3a=3aFormatters=3a=3aTransitive.html (Sorry, this is a Japanese document only.)

require 'rexml/document'
require 'rexml/formatters/transitive'

This documentation explicitly requires 'rexml/formatters/transitive'.

Do you think we should be able to use REXML::Formatters::Transitive.new with require "rexml" as well as REXML::Formatters::Pretty.new?

irb(main):001> require 'rexml'
=> true
irb(main):002> REXML::Formatters::Pretty.new
=> #<REXML::Formatters::Pretty:0x000000012333db18 @compact=false, @ie_hack=false, @indentation=2, @level=0, @width=80>
irb(main):003> REXML::Formatters::Transitive.new
(irb):3:in '<main>': uninitialized constant REXML::Formatters::Transitive (NameError)
	from <internal:kernel>:168:in 'Kernel#loop'
	from /Users/naitoh/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/irb-1.14.3/exe/irb:9:in '<top (required)>'
	from /Users/naitoh/.rbenv/versions/3.4.1/bin/irb:25:in 'Kernel#load'
	from /Users/naitoh/.rbenv/versions/3.4.1/bin/irb:25:in '<main>'

See: #228

[kou]

It's required lazy:

rexml/lib/rexml/document.rb

Line 391 in b70388c

require_relative "formatters/transitive"

But the approach may be slow on JRuby. See also: #219

So, I'm OK with requiring it non-lazy. But it should be done in document.rb not node.rb because it's not used in node.rb.

[naitoh]

It's required lazy:

rexml/lib/rexml/document.rb

Line 391 in b70388c

require_relative "formatters/transitive"

But the approach may be slow on JRuby. See also: #219

So, I'm OK with requiring it non-lazy. But it should be done in document.rb not node.rb because it's not used in node.rb.

I see.
Thanks.

@Beagle123
Could you change this PR to conform to the above policy?

Specifically, they are as follows.

1. Remove the following lazy require.

• rexml/lib/rexml/document.rb

  Line 391 in b70388c

  require_relative "formatters/transitive"

• rexml/lib/rexml/element.rb

  Line 1508 in b70388c

  require_relative "formatters/transitive"

2. Add non-lazy require in document.rb, not node.rb.

[kou]

Ah, I didn't notice that we have a lazy require in element.rb too.
Then element.rb is better than document.rb because document.rb depends on element.rb.

[naitoh]

Ah, I didn't notice that we have a lazy require in element.rb too. Then element.rb is better than document.rb because document.rb depends on element.rb.

OK, I see.

@Beagle123
Could you change this PR to conform to the above policy?

Specifically, they are as follows.

1. Remove the following lazy require.

• rexml/lib/rexml/document.rb

  Line 391 in b70388c

  require_relative "formatters/transitive"

• rexml/lib/rexml/element.rb

  Line 1508 in b70388c

  require_relative "formatters/transitive"

2. Add non-lazy require in element.rb, not node.rb.

[Beagle123]

Hi:

I think I've made the changes requested.

However, I don't think my original issue is resolved. My issue was that using Pretty.rb resulted in my text lines having a bunch of whitespace inserted so that the XML file looks indented, but all my text has drastically changed. I was not able to require REXML::Formatters::Transitive as it was not found. I downloaded Transitive.rb, but the output was totally disjointed. I had to hack Pretty.rb to make it not alter my text, and that works. But this is not a good situation for users. I assure you that nobody will be happy with the output from Transitive, and the only choice is to have their text nodes altered by Pretty.rb.

I've uploaded my new version of Transitive.rb. I concede that it is a change from the current version, but it does the desireable behavior that Transitive is supposed to do: Pretty output with preserved text lines.

Thanks,
Eric

[naitoh]

I think I've made the changes requested.

Thanks.
Please make some more corrections.

[naitoh]

This position is lazy require.
Please move this line at the beginning position of this file so that it is non-lazy require.

See:

rexml/lib/rexml/element.rb

Lines 1 to 8 in b70388c

	# frozen_string_literal: false
	require_relative "parent"
	require_relative "namespace"
	require_relative "attribute"
	require_relative "cdata"
	require_relative "xpath"
	require_relative "parseexception"

[naitoh]

Please remove this empty line.

[naitoh]

However, I don't think my original issue is resolved.

I would like to discuss that issue in #230.