Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount docs as first mount #882

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Mount docs as first mount #882

wants to merge 18 commits into from

Commits on Sep 28, 2022

  1. Move all docs mounts to the first mount

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4e0918c View commit details
    Browse the repository at this point in the history

  2. Restore the working directory last; Unmount docs via exit hook

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    d7c4461 View commit details
    Browse the repository at this point in the history

  3. Test that the docs mount is first

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    9fd1d78 View commit details
    Browse the repository at this point in the history

  4. Restore the wd last

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    fd8bbb5 View commit details
    Browse the repository at this point in the history

  5. comments

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    888c2a3 View commit details
    Browse the repository at this point in the history

  6. document

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    b8ce6bc View commit details
    Browse the repository at this point in the history

  7. Update NEWS.md

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    22d9983 View commit details
    Browse the repository at this point in the history

  8. devtools::document() (GitHub Actions)

    @schloerke
    schloerke committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    357b299 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Use on.exit(after = FALSE) to make logic cleaner

    @schloerke
    schloerke committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    11110cb View commit details
    Browse the repository at this point in the history

  2. Add support for Plumber$mount(..., after=); ... is empty; after… 

    … is like `append(after=)` for mount order
    @schloerke
    schloerke committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    6645ba2 View commit details
    Browse the repository at this point in the history

  3. Remove pr_private logic and add utilize pr$mount(after=0)

    @schloerke
    schloerke committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a9ebbf9 View commit details
    Browse the repository at this point in the history

  4. Add support for pr_mount(..., after=)

    @schloerke
    schloerke committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5db42eb View commit details
    Browse the repository at this point in the history

  5. Test: Mount a third router with after=0

    @schloerke
    schloerke committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    39d94e6 View commit details
    Browse the repository at this point in the history

  6. devtools::document() (GitHub Actions)

    @schloerke
    schloerke committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    55878dd View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Add another news entry

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    48d98a7 View commit details
    Browse the repository at this point in the history

  2. Remove prior mount if it exists

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    4032882 View commit details
    Browse the repository at this point in the history

  3. Add breaking news entry about mounts being removed before added

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    11ae052 View commit details
    Browse the repository at this point in the history

  4. Use rlang::is_interactive() instead of base::interactive()

    @schloerke
    schloerke committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    777cf62 View commit details
    Browse the repository at this point in the history