Mount docs as first mount #882
Conversation
|
Sorry, I don't understand these changes--can you walk me through them tomorrow? |
|
Will do! |
|
I suggest adding a |
… is like `append(after=)` for mount order
|
| @@ -299,7 +307,15 @@ Plumber <- R6Class( | |||
| path <- paste0(path, "/") | |||
| } | |||
|
|
|||
| private$mnts[[path]] <- router | |||
| # Remove prior mount if it exists | |||
| self$unmount(path) | |||
There was a problem hiding this comment.
I don't think you want to do this unmount...? With #883, you'll be able to mount two subrouters to one path and have one fall through to the other.
There was a problem hiding this comment.
I'll be sure to address that in the PR. There's a lot of decisions to be made in #883
For now, I'd like to keep existing behavior where it was overwritten.
There was a problem hiding this comment.
- Bullet point added in description of Mounted router fall back to parent router when route is not found #883
There was a problem hiding this comment.
And if you still do want to unmount, I think you would then need to factor in how it affects the after index if it's a non-NULL, non-zero value.
There was a problem hiding this comment.
Hmmmm. Let's keep this in draft to see if we're even going to merge #883
Fixes #881
Other changes:
exithooks are run.PR task list:
devtools::document()cc @aronatkins