Add content job template default requests and limits #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkegley
requested review from
aronatkins,
christierney,
zackverham and
a team
as code owners
dbkegley
commented
Jan 6, 2025
| {{- with $templateData.pod.hostAliases }} | ||
| hostAliases: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} |
There was a problem hiding this comment.
FYI @samcofer I noticed while working on this PR that we forgot to add the hostAliases setting to the helm chart's job template version. Sorry about that, I'll try to remember to update those templates going forward
This was referenced Jan 6, 2025
aronatkins
approved these changes
Jan 6, 2025
charts/rstudio-connect/values.yaml
Outdated
| # -- sets the default resource requests and limits for Jobs launched by Connect | ||
| # -- to be used when none are provided in the content runtime settings | ||
| resources: {} | ||
| # requests: |
There was a problem hiding this comment.
Do we need to provide empty dictionaries by default for requests and limits?
jforest
approved these changes
Jan 6, 2025
dbkegley
force-pushed
the
kegs/job-resources-overrides
branch
from
9ef04b9 to
72fc140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting content job default resource requests and limits configurations via the values file.
If no defaults are provided in the values file then Kubernetes cluster/namespace defaults are still respected.
Connect resource settings provided globally by the
Scheduler.*RequestandScheduler.*Limitsettings or by the content runtime settings both take precedence over the defaults from the values file.Replaces: #630
Note there is a separate discussion required to determine if we should specify sane defaults in our values file, but these settings are a good escape hatch for now. see also: #630 (comment)