fix default slice start in parser #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V0ldek
force-pushed
the
v0ldek/#546-parser-incorrect-default-start
branch
from
35428e9 to
090f341
Compare
According to the spec the start of a slice when not explicitly specified depends on the sign of the step. The current implementation always used FromStart(0), which is correct for forward steps, but for backward steps it's supposed to be starting from the end - FromEnd(1). This affects only `rsonpath-syntax`.
V0ldek
force-pushed
the
v0ldek/#546-parser-incorrect-default-start
branch
from
090f341 to
b75a524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
According to the spec the start of a slice when not explicitly specified depends on the sign of the step. The current implementation always used FromStart(0), which is correct for forward steps, but for backward steps it's supposed to be starting from the end - FromEnd(1).
This affects only
rsonpath-syntax.Issue
Resolves: #546
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.