Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests targeting the TV denoising code were broken or flakey.
The idea behind these tests is to take a simple "ground truth" map, add some Gaussian noise, and then run TV denoising. Ideally, the output should be closer to the noise-free "ground truth" than the input.
But these tests were not faithfully reporting this because the map comparison was done by computing a normalized RMS between the two maps. The Pearson correlation, computed in real space, appears to provide a more robust signal, and this PR implements this change.
During the implementation, I realized that I was confused by the
rsmap.Map
methods. There is a.to_numpy()
method inherited frompandas
that provides theF
,PHI
,SIGF
columns as numpy arrays. Useful, but for a moment, I thought I was getting real space maps. Therefore, this PR additionally implements a handy function that computes a3d_numpy_map
, which hopefully will make this easier and clearer going forward.