Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize parameter scan metadata #95

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

generalize parameter scan metadata #95

wants to merge 8 commits into from
+188 −163

Conversation

tjlane
Copy link
Collaborator

@tjlane tjlane commented Jan 22, 2025 •
edited
Loading

Make the TvDenoiseResult class more general, so that it can work for any parameter scan.

To Do:

  • move the new dataclass into validate.py
  • refactor tests so that they appear in the correct .py files
  • JSON has no tuple, so right now round-trip tests are failing
  • make it so that multiple parameters can be read/written to the same JSON file

idea: instead of passing around parameter names as globals, subclass the current ScanMetadata object

@tjlane tjlane self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tjlane tjlane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tjlane