Review tests in microdnf directory

dnf-behave-tests/dnf/microdnf/config-with-repos.feature → dnf-behave-tests/dnf/config-with-repos.feature

@@ -1,5 +1,4 @@
 @dnf5
-@no_installroot
 # no bug, PR https://github.com/rpm-software-management/libdnf/pull/882
 Feature: Repositories configured in main configuration file
 
@@ -23,7 +22,7 @@ Background: Configure repositories in the main configuration file
 
 
 Scenario: Repositories configured only in the main configuration file
-   When I execute microdnf with args "repo list --all"
+   When I execute dnf with args "repo list --all"
    Then the exit code is 0
     And stdout is
      """
@@ -39,7 +38,7 @@ Scenario: Repositories configured in the main configuration file and in *.repo f
     And I use repository "dnf-ci-fedora-updates" with configuration
         | key     | value |
         | enabled | 0     |
-   When I execute microdnf with args "repo list --all"
+   When I execute dnf with args "repo list --all"
    Then the exit code is 0
     And stdout is
      """

dnf-behave-tests/dnf/environment.py

@@ -172,46 +172,6 @@ def get_dnf4_cmd(self, context):
 
         return result
 
-    def get_microdnf_cmd(self, context):
-        result = ["microdnf"]
-        result.append(self.assumeyes_option)
-
-        # installroot can't be set via context for safety reasons
-        if self.installroot and self.installroot != "/":
-            result.append("--installroot={0}".format(self.installroot))
-
-            # Microdnf in installroot mode requires the following options to be set.
-            # The calculation of their default values is not implemented in microdnf.
-            # New rules for default values are still being discussed.
-            result.append("--noplugins")
-            result.append("--config={0}".format(os.path.join(self.installroot, "etc/dnf/dnf.conf")))
-            result.append("--setopt=reposdir={0}".format(os.path.join(self.installroot, "etc/yum.repos.d")))
-            result.append("--setopt=varsdir={0}".format(os.path.join(self.installroot, "etc/dnf/vars")))
-            result.append("--setopt=cachedir={0}".format(os.path.join(self.installroot, "var/cache/yum")))
-
-        releasever = self._get("releasever")
-        if releasever:
-            result.append("--releasever={0}".format(releasever))
-
-        module_platform_id = self._get("module_platform_id")
-        if module_platform_id:
-            result.append("--setopt=module_platform_id={0}".format(module_platform_id))
-
-        # Plugins support is disabled in installroot mode. We can't disable/enable plugins.
-        if not self.installroot or self.installroot == "/":
-            disable_plugins = self._get("disable_plugins")
-            if disable_plugins:
-                result.append("--noplugins")
-            plugins = self._get("plugins") or []
-            for plugin in plugins:
-                result.append("--enableplugin='{0}'".format(plugin))
-
-        setopts = self._get("setopts") or {}
-        for key, value in setopts.items():
-            result.append("--setopt={0}={1}".format(key, value))
-
-        return result
-
     def get_dnf5_cmd(self, context):
         result = [self.dnf_command]
         result.append(self.assumeyes_option)

dnf-behave-tests/dnf/error_messages.feature

@@ -30,7 +30,7 @@ Scenario: Repository option 'proxy_username' is set but not 'proxy_password'
    Then the exit code is 1
     And stderr contains "'proxy_username' is set but not 'proxy_password'"
 
-@dnf5
+
 Scenario: Nested exception is printed when max parallel downloads are exceeded
   Given I use repository "dnf-ci-fedora"
     And I configure dnf with

dnf-behave-tests/dnf/exclude_from_weak.feature

@@ -145,6 +145,7 @@ Scenario: Upgrade ignores unmet recommends of installed package even when anothe
         | upgrade       | PackageA-2.0-1.x86_64                     |
         | install       | PackageC-2.0-1.x86_64                     |
 
+
 @bz2048394
 @bz2033130
 Scenario: Upgrade will not ignores unmet recommends of installed package when the rich dependency was satisfied

dnf-behave-tests/dnf/install-nodocs.feature

@@ -0,0 +1,35 @@
+@dnf5
+Feature: install command on packages and their docs
+
+
+Scenario: Install a documentation package from local repodata
+Given I use repository "microdnf-install-nodocs"
+ When I execute dnf with args "install man-pages"
+ Then the exit code is 0
+  And transaction is following
+      | Action        | Package                                   |
+      | install       | man-pages-0:4.16-3.fc29.x86_64            |
+  And file "/usr/share/doc/man-pages/README" exists
+
+
+@bz1769831
+Scenario: Install package with option from local repodata with local packages
+Given I use repository "microdnf-install-nodocs"
+ When I execute dnf with args "--setopt=tsflags=nodocs install man-pages"
+ Then the exit code is 0
+  And transaction is following
+      | Action        | Package                                   |
+      | install       | man-pages-0:4.16-3.fc29.x86_64            |
+  And file "/usr/share/doc/man-pages/README" does not exist
+
+
+@bz1771012
+Scenario: Install package with --nodocs option from local repodata with local packages
+Given I use repository "microdnf-install-nodocs"
+  And I execute dnf with args "--nodocs install man-pages"
+ Then the exit code is 0
+  And transaction is following
+      | Action        | Package                                   |
+      | install       | man-pages-0:4.16-3.fc29.x86_64            |
+  And file "/usr/share/doc/man-pages/README" does not exist
+

dnf-behave-tests/dnf/install-pkgspec.feature

@@ -15,6 +15,17 @@ Scenario: Install an RPM by name
         | install-dep   | setup-0:2.12.1-1.fc29.noarch          |
 
 
+@bz1734350
+Scenario: Install packages by name from remote repodata with remote packages
+Given I use repository "dnf-ci-fedora" as http
+ When I execute dnf with args "install lame"
+ Then the exit code is 0
+  And transaction is following
+      | Action        | Package                                   |
+      | install       | lame-0:3.100-4.fc29.x86_64                |
+      | install-dep   | lame-libs-0:3.100-4.fc29.x86_64           |
+
+
 Scenario: Install an RPM by name-version
    When I execute dnf with args "install filesystem-3.9"
    Then the exit code is 0

dnf-behave-tests/dnf/microdnf/install_weak_deps.feature → dnf-behave-tests/dnf/install-weak-deps.feature

@@ -1,3 +1,4 @@
+@dnf5
 Feature: Tests --setopt=install_weak_deps=
 
 
@@ -6,19 +7,19 @@ Background: Prepare environment
 
 
 Scenario: Install "abcde" without weak dependencies
-   When I execute microdnf with args "install --setopt=install_weak_deps=0 abcde"
+   When I execute dnf with args "install --setopt=install_weak_deps=0 abcde"
    Then the exit code is 0
-    And microdnf transaction is
+    And transaction is following
         | Action        | Package                                   |
         | install       | abcde-0:2.9.2-1.fc29.noarch               |
-        | install       | wget-0:1.19.5-5.fc29.x86_64               |
+        | install-dep   | wget-0:1.19.5-5.fc29.x86_64               |
 
 
 Scenario: Install "abcde" with weak dependencies
-   When I execute microdnf with args "install --setopt=install_weak_deps=1 abcde"
+   When I execute dnf with args "install --setopt=install_weak_deps=1 abcde"
    Then the exit code is 0
-    And microdnf transaction is
+    And transaction is following
         | Action        | Package                                   |
         | install       | abcde-0:2.9.2-1.fc29.noarch               |
-        | install       | flac-0:1.3.2-8.fc29.x86_64                |
-        | install       | wget-0:1.19.5-5.fc29.x86_64               |
+        | install-weak  | flac-0:1.3.2-8.fc29.x86_64                |
+        | install-dep   | wget-0:1.19.5-5.fc29.x86_64               |

dnf-behave-tests/dnf/makecache.feature

@@ -1,11 +1,80 @@
 @dnf5
-Feature: makecache command 
+Feature: makecache command
 
 
+Scenario: Create a metadata cache using "makecache" and then test that "repoquery" does not download metadata
+  Given I use repository "dnf-ci-fedora" as http
+  When I execute dnf with args "makecache"
+  Then the exit code is 0
+  And stderr matches line by line
+      """
+      Updating and loading repositories:
+      dnf-ci-fedora test repository .*
+      Repositories loaded.
+      """
+  When I execute dnf with args "repoquery nodejs"
+  Then the exit code is 0
+   And stdout is
+      """
+      nodejs-1:5.12.1-1.fc29.src
+      nodejs-1:5.12.1-1.fc29.x86_64
+      """
+  And stderr is
+      """
+      Updating and loading repositories:
+      Repositories loaded.
+      """
+
+
+Scenario: Tests that "repoquery" downloads metadata (creates a cache) and then "makecache" does not download metadada
+  Given I use repository "dnf-ci-fedora" as http
+  When I execute dnf with args "repoquery nodejs"
+  Then the exit code is 0
+  And stderr matches line by line
+      """
+      Updating and loading repositories:
+      dnf-ci-fedora test repository .*
+      Repositories loaded.
+      """
+   And stdout is
+      """
+      nodejs-1:5.12.1-1.fc29.src
+      nodejs-1:5.12.1-1.fc29.x86_64
+      """
+  When I execute dnf with args "makecache"
+  Then the exit code is 0
+   And stdout is
+      """
+      Metadata cache created.
+      """
+   And stderr is
+      """
+      Updating and loading repositories:
+      Repositories loaded.
+      """
+
+
+Scenario: makecache with skip_if_unavailable=0 and non existent repo doesn't succeed
+Given I configure a new repository "non-existent" with
+      | key                 | value                               |
+      | baseurl             | https://www.not-available-repo.com/ |
+      | enabled             | 1                                   |
+      | skip_if_unavailable | 0                                   |
+ When I execute dnf with args "makecache"
+ Then the exit code is 1
+  And stdout is empty
+  And stderr contains "Updating and loading repositories:"
+  And stderr contains "non-existent test repository"
+  And stderr contains "Failed to download metadata \(baseurl: \"https://www.not-available-repo.com/\"\) for repository \"non-existent\""
+
+
+@xfail
+# Missing --timer option, reported as https://github.com/rpm-software-management/dnf5/issues/812
 @bz1745170
 Scenario: disabled makecache --timer does not invalidate cached metadata
 Given I use repository "dnf-ci-fedora" as http
   And I successfully execute dnf with args "makecache"
  When I execute dnf with args "makecache --timer --setopt=metadata_timer_sync=0"
+ Then the exit code is 0
   And I execute dnf with args "install setup"
  Then stderr does not contain "dnf-ci-fedora test repository"

dnf-behave-tests/dnf/metadata.feature

@@ -22,11 +22,50 @@ Given I copy directory "{context.scenario.repos_location}/dnf-ci-fedora" to "/te
   And I execute "sleep 2s"
  Then I execute dnf with args "upgrade"
  Then the exit code is 0
- Then I execute dnf with args "list"
+ Then I execute dnf with args "--cacheonly list"
  Then the exit code is 0
   And stdout contains "\s+wget.src\s+1.19.5-5.fc29\s+testrepo"
 
 
+@bz1771147
+Scenario: dnf respects metadata_expire (with default of 48 hours)
+Given I use repository "simple-base" as http
+ When I execute dnf with args "repoquery labirinto"
+ Then the exit code is 0
+  And stdout is
+  """
+  labirinto-0:1.0-1.fc29.src
+  labirinto-0:1.0-1.fc29.x86_64
+  """
+ # since libdnf measures the metadata file age in whole seconds, wait till it changes
+ When I sleep for "1" seconds
+  And I execute dnf with args "repoquery labirinto"
+ Then the exit code is 0
+  And stderr is
+  """
+  Updating and loading repositories:
+  Repositories loaded.
+  """
+  And stdout is
+  """
+  labirinto-0:1.0-1.fc29.src
+  labirinto-0:1.0-1.fc29.x86_64
+  """
+ When I execute dnf with args "--refresh repoquery labirinto"
+ Then the exit code is 0
+  And stdout is
+  """
+  labirinto-0:1.0-1.fc29.src
+  labirinto-0:1.0-1.fc29.x86_64
+  """
+  And stderr matches line by line
+  """
+  Updating and loading repositories:
+  simple-base test repository .*
+  Repositories loaded.
+  """
+
+
 @bz1866505
 Scenario: I cannot create/overwrite a file in /etc from local repository
 # This directory structure is needed at the repo source so that it can be matched on the system running dnf