Review tests in microdnf directory #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it really worth it to keep the microdnf tests in the separate microdnf directory if it's just an alias for the dnf5 command? In past, we had run tests explicitly with "dnf", "dnf-3" and "yum", maybe it was even possible to switch the command for all the tests, I am not sure exactly. But having the test at one place and only switching the command name seems better than to have a somewhat duplicate sets of tests. I can imagine it might be a lot of work to change it, but it would be more maintainable later. |
Most of them are duplicate to install-xml-base.feature
They are mostly present in reinstall.feature and reinstall-reason.feature
Also drops one duplicate basic config tests
Also removes one duplicate tag in original.
Also updates the existing makecache test and annotates it.
They have basically the same functinality as the current dnf module-reset but they are more structured and use appropriate steps.
One duplicate test is removed and the feature is specialized to multiline config.
Also one test moved to dnf and one dnf test updated
|
I have update the PR to de-duplicate and merge the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the tests are duplicate to regular dnf5 tests but they are run through the
microdnfcommand.