Increased OpenGL ES compatibility #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change indices from unsigned int to unsigned short since glDrawElements doesn't support GL_UNSIGNED_INT unless you have the GL_OES_element_index_uint extension change GL_RED to GL_LUMINANCE since GL_RED doesn't exist in OpenGL ES
| @@ -338,8 +338,8 @@ texture_atlas_upload( texture_atlas_t * self ) | |||
| } | |||
| else | |||
| { | |||
| glTexImage2D( GL_TEXTURE_2D, 0, GL_RED, self->width, self->height, | |||
| 0, GL_RED, GL_UNSIGNED_BYTE, self->data ); | |||
| glTexImage2D( GL_TEXTURE_2D, 0, GL_LUMINANCE, self->width, self->height, | |||
There was a problem hiding this comment.
We might have a conflict here with OpenGL > 3
|
Thanks for the PR. I think it needs more testing from the community because I suspect it might break things (even if Travis is ok) because of the change from int to short. |
|
Sorry for the long delay, can you update your PR (rebase) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change indices from unsigned int to unsigned short since glDrawElements doesn't support GL_UNSIGNED_INT unless you have the GL_OES_element_index_uint extension
change GL_RED to GL_LUMINANCE since GL_RED doesn't exist in OpenGL ES