Ptt/init reporting #434
Merged
Ptt/init reporting #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsutherland333
requested changes
Sep 4, 2024
include/comm_manager.h
Outdated
|
|
||
| void send_parameter_list(); | ||
| // void send_parameter_list(); |
There was a problem hiding this comment.
It would be better to remove old code than comment it out
src/comm_manager.cpp
Outdated
| @@ -129,7 +129,10 @@ void CommManager::param_request_list_callback(uint8_t target_system) | |||
| if (target_system == sysid_) { send_params_index_ = 0; } | |||
| } | |||
|
|
|||
| void CommManager::send_parameter_list() { send_params_index_ = 0; } | |||
| //void CommManager::send_parameter_list() | |||
src/comm_manager.cpp
Outdated
| @@ -526,6 +534,23 @@ void CommManager::send_named_value_float(const char * const name, float value) | |||
|
|
|||
| void CommManager::send_next_param(void) | |||
| { | |||
| //PTT Hack | |||
There was a problem hiding this comment.
Should we figure out a more permanent solution for this before merging these changes into main?
There was a problem hiding this comment.
removed hack, note initialization status will not be reported, that will require more code and maybe a request from rosflight io
There was a problem hiding this comment.
yes we should think of a more permanent solution
bsutherland333
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes have been made to allow the board to send initialization status messages to the companion computer.
This requires also updating the board supports package in the varmint_h7 directory.