adding API change for spin_until_complete #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevemacenski <[email protected]>
audrow
approved these changes
Feb 13, 2023
|
Thanks, @SteveMacenski! |
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
Signed-off-by: stevemacenski <[email protected]> (cherry picked from commit fd9adb8)
This was referenced Feb 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
Signed-off-by: stevemacenski <[email protected]> (cherry picked from commit fd9adb8) # Conflicts: # source/Tutorials/Advanced/FastDDS-Configuration.rst # source/Tutorials/Beginner-Client-Libraries/Custom-ROS2-Interfaces.rst
Wait, the associated PRs haven't been merged yet. So we shouldn't merge this in, as the documentation doesn't reflect reality. @audrow would you mind doing a revert here? |
|
Yeah, I'm surprised to see this merged |
|
Yeah, I'll do the revert. Sorry I thought the PRs had landed. |
audrow
added a commit
that referenced
this pull request
Feb 13, 2023
audrow
added a commit
that referenced
this pull request
Feb 13, 2023
|
Here's a draft PR adding this change back in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: stevemacenski [email protected]
Replacing #2798