Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "adding API change for spin_until_complete" #3333

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Revert "adding API change for spin_until_complete" #3333

merged 1 commit into from
Feb 13, 2023

Conversation

audrow
Copy link
Member

@audrow audrow commented Feb 13, 2023

Reverts #3328

clalancette
clalancette approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks. @audrow Can you also open a "Revert revert" PR (as a draft) so we have this ready to go when we do make the API change?

@audrow audrow merged commit e0ec7a7 into rolling Feb 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the revert-3328-spin_until2 branch February 13, 2023 21:56
audrow added a commit that referenced this pull request Feb 13, 2023
@audrow
Revert "Revert "adding API change for spin_until_complete (#3328)" (#…
402bdd5 
…3333)"

This reverts commit e0ec7a7.
@audrow audrow mentioned this pull request Feb 13, 2023
Closed
@mergify mergify bot mentioned this pull request Feb 13, 2023
Closed
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@audrow @mergify
Revert "adding API change for spin_until_complete (#3328)" (#3333)
6e15e02 
This reverts commit fd9adb8.

(cherry picked from commit e0ec7a7)
@mergify mergify bot mentioned this pull request Feb 13, 2023
Closed
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@audrow @mergify
Revert "adding API change for spin_until_complete (#3328)" (#3333)
ceb3f32 
This reverts commit fd9adb8.

(cherry picked from commit e0ec7a7)

# Conflicts:
#	source/Tutorials/Advanced/FastDDS-Configuration.rst
#	source/Tutorials/Beginner-Client-Libraries/Custom-ROS2-Interfaces.rst
@christophebedard christophebedard mentioned this pull request Apr 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@audrow @clalancette