-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privacy_msgs: 1.1.0-1 in 'humble/distribution.yaml' [bloom] #42868
base: master
Are you sure you want to change the base?
privacy_msgs: 1.1.0-1 in 'humble/distribution.yaml' [bloom] #42868
Conversation
f7637ac
to
5f481f7
Compare
5f481f7
to
9a3566a
Compare
release: | ||
tags: | ||
release: release/humble/{package}/{version} | ||
url: https://github.com/ros4hri/privacy_msgs-release.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@severin-lemaignan can we move this release repository to ros2-gbp?
I can start the PR and mirroring process to add it to the ros4hri team: https://github.com/ros2-gbp/ros2-gbp-github-org/blob/latest/ros4hri.tf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please! (sorry, I always forget how the ros2-gbp process work. It is certainly documented somewhere, but I just don't seem to have the required mental bandwidth to handle it properly 😔)
An additional note after taking a moment to do full review. I don't think this meets REP-144 criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a little bit too generic for a REP 144 package naming standards. https://www.ros.org/reps/rep-0144.html
This looks to have one message which is very application specific. Which doesn't justify claiming the name privacy
for the whole ROS ecosystem.
Please use a name that explains the scope of where this package is expected to be reused in a prefix otherwise making the name more specific. Possibly the privacy standard that it's targeted for, or the project that it's going to be used for.
thanks for the feedback. I'll revise accordingly. |
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
Increasing version of package(s) in repository
privacy_msgs
to1.1.0-1
:humble/distribution.yaml
0.10.7
null
privacy_msgs