Add PySide6 to rosdep keys

[samyarsadat]

Please add the following dependency to the rosdep database.

Package name:

PySide6

Package Upstream Source:

https://github.com/qtproject/pyside-pyside-setup

Purpose of using this:

This package is a Python wrapper for Qt 6. It allows one to create Qt applications using Python.

Links to Distribution Packages

• PyPi: https://pypi.org/project/PySide6/

[marcoag]

Standard pip disclaimer: ROS packages that depend on pip keys cannot be released into a ROS distribution. They can only be depended on by from-source builds. Because of this, system packages are highly preferred to pip packages.

[clalancette]

This one ends up being tricky.

We know that system packages for pyside6 are coming; they are already available for Ubuntu Oracular and Debian Sid.

However, as a matter of course we don't usually add in keys for pre-release distributions.

There are 2 ways we could go here:

1. Take in this python3-pyside6-pip key for now, and later add in a python3-pyside6 key.
2. Right now go for a python3-pyside6 key, and fill it out with pip for everything except for very new Ubuntu and Debian distributions.

Personally, I think we should go for 2, but I can be convinced otherwise.

@mjcarroll @alsora Any thoughts here?

[samyarsadat]

I also think number 2 is a better option, but there is one small issue with it.
As with PySide2, the PySide6 binary packages are split up into different modules (ex. python3-pyside6.qtqml, python3-pyside6.qtgui, etc.), so keys for all of those would have to be added as well (at least for the latest Debian and Ubuntu distros that are going to use system packages).

[clalancette]

As with PySide2, the PySide6 binary packages are split up into different modules (ex. python3-pyside6.qtqml, python3-pyside6.qtgui, etc.), so keys for all of those would have to be added as well (at least for the latest Debian and Ubuntu distros that are going to use system packages).

Yeah, agreed. However, we can do that piecemeal. What particular parts of PySide6 are you interested in?

[alsora]

I agree with option 2.
It also seems slightly more consistent with the rest of the file, where the -pip suffix is used only for those dependencies that always come from pip, while no suffix is used for dependencies where we use a mixture of pip and system packages.

[samyarsadat]

As with PySide2, the PySide6 binary packages are split up into different modules (ex. python3-pyside6.qtqml, python3-pyside6.qtgui, etc.), so keys for all of those would have to be added as well (at least for the latest Debian and Ubuntu distros that are going to use system packages).

Yeah, agreed. However, we can do that piecemeal. What particular parts of PySide6 are you interested in?

That works. I currrently need qtcore, qtgui, qtconcurrent, qtqml, and qtwidgets.

Should there be one key named python3-pyside6 that installs PySide6 thourgh pip on distros with no system packages and libpyside6-dev, python3-pyside6.qtcore, python3-pyside6.qtgui, python3-pyside6.qtconcurrent, python3-pyside6.qtqml, and python3-pyside6.qtwidgets on distros with system packages, or should there be individual keys for all of the different modules?

[clalancette]

or should there be individual keys for all of the different modules?

I would start with individual keys. That gives packagers maximum control. If it turns out that there is really a need for a "consolidated" key, we can always add that in later.

[samyarsadat]

I've updated the python3-pyside6 key and added all the new keys for the different modules.
I previously said that I needed qtcore, qtgui, qtconcurrent, qtqml, and qtwidgets, but I've added a few more:
qtasyncio, qtcharts, qtdatavisualization, qttest.

[github-actions]

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

Changes since review

[nuclearsandwich]

@sloretz I modified the PR to include trixie definitions, would you please give it an updated review with my changes.

[github-actions]

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

[clalancette]

I updated this to be more forwards-compatible. With this in place, I'm happy, so I'm going to approve. I would still like another approval before merging.

[cottsay]

Looks good. Could use an OS-level wildcard for the pip rule on python3-pyside6 and drop the explicit osx and rhel rules if you like.

[clalancette]

Looks good. Could use an OS-level wildcard for the pip rule on python3-pyside6 and drop the explicit osx and rhel rules if you like.

Thanks for the review. I'm going to leave things as-is for now, we can always follow-up later on.