Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkin_simple: 0.1.2-1 in 'indigo/distribution.yaml' [bloom] #14486

Closed
wants to merge 1 commit into from

Conversation

fmina
Copy link
Contributor

@fmina fmina commented Apr 7, 2017

Increasing version of package(s) in repository catkin_simple to 0.1.2-1:

@dirk-thomas
Copy link
Member

@ros/ros_team I am not sure if this should be release. Any opinions?

@wjwwood
Copy link
Member

wjwwood commented Apr 7, 2017

I don't think it should be released from a fork. As for releasing it in general, we had reservations about supporting packages which use it on the build farm. I've also laid out in the past what needs to be done before it should be release in the past, and in that post I mentioned that is should get a new name if someone forks it:

If you're interested, you could take over and release it. Or you could fork it as is and release it under a different name.

-- catkin/catkin_simple#29 (comment)

So, I think that if @fmina wants to release it and support it, then the name should be adjusted to fmina_catkin_simple (in the package.xml not just the repository name here) or something similar.

@dirk-thomas
Copy link
Member

I agree with @wjwwood on this. Therefore I will close the PR. Please feel free to contribute to improve catkin_simple or consider forking and releasing it under a different name (e.g. with a prefix).

@dirk-thomas dirk-thomas closed this Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants