-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add script to check duplicates keys #520
base: master
Are you sure you want to change the base?
add script to check duplicates keys #520
Conversation
test/test_rosdep_duplicates_key.py
Outdated
@@ -0,0 +1,55 @@ | |||
# Copyright (c) 2012, Willow Garage, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the year. And if you'd like contribute it to OSRF instead of Willow Garage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could add arguments to allow it to take local files that would be much more useful.
That way we and anyone else maintaining rosdep keys can add it to their CI for the repo with rosdep keys.
I was originally going to suggest moving it to the rosdistro repo, but I think it makes more sense here so anyone with rosdep can test keys. But it also doesn't really make sense to have this registered in this repository as a unit test. Since it's not a failure of this repository that there are duplicate keys. So I'd suggest moving this over into the source section instead of the tests. Though it could continue to behave as a unit test for easy report generating in downstream CI.
For everyone's info (and my book keeping), this is waiting on requested changes from @tfoote to make this a script rather than a test, and optionally to make it operate on local files. |
sorry for late, I have copied the https://github.com/ros/rosdistro/blob/3a6a34f7cb99c198f4e009d0943ccd9f765b59ab/scripts/check_duplicates.py, which can
are welcome |
we have noticed that some rosdep keys are multiply defined and that causes un-exepected behavior, for example a few month ago, if you have package with
then
ros-indigo-pocketsphinx
ros package is installed, but nowrosdep install
installslibsphinxbase
system library, https://github.com/ros/rosdistro/pull/14126/filesthe result of this script is as follows