Skip to content

[JSB] added fixes to mantain the joint names order (backport #1572) #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 9, 2025

I've add some fixes to the codes to retain the proper naming order. it will maintain the same naming as the state_interfaces. Most of the time. it is same as requested.

I confirm that it is working as expected. The following are the results after testing on the TIAGo robot

With master branch:

header:
  stamp:
    sec: 27
    nanosec: 634000000
  frame_id: ''
name:
- wheel_right_joint
- torso_lift_joint
- head_2_joint
- arm_1_joint
- head_1_joint
- gripper_right_finger_joint
- arm_2_joint
- arm_3_joint
- gripper_left_finger_joint
- arm_6_joint
- wheel_left_joint
- arm_7_joint
- arm_5_joint
- arm_4_joint
position:
- -0.01883440381531276
- 0.14992120022237515
- -2.1771094615985476e-07
- 0.5000004071831876
- 2.679102557578972e-07
- 1.498072885788662e-09
- -1.3399972501658528
- -0.47999627762595054
- 1.6320817259907867e-07
- 1.3700221974953228
- 0.00558756172246877
- -5.676095425677374e-06
- -1.4900038801677784
- 1.9399743393071844
velocity:
- .nan
- -0.009820570088929573
- 0.00010381144165565768
- -0.0004520477620429137
- -0.0005884276721260586
- 0.0003904782235743167
- 0.0026640572724227402
- 0.004136899003124899
- -0.0002584158488683724
- 0.02222271007923489
- .nan
- -0.0019689225065199385
- -0.004196435823050384
- -0.025497848941894285
effort:
- .nan
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- .nan
- 0.0
- 0.0
- 0.0
---

With the fix proposed in this PR:

header:
  stamp:
    sec: 3
    nanosec: 7000000
  frame_id: ''
name:
- wheel_right_joint
- wheel_left_joint
- torso_lift_joint
- arm_1_joint
- arm_2_joint
- arm_3_joint
- arm_4_joint
- arm_5_joint
- arm_6_joint
- arm_7_joint
- gripper_left_finger_joint
- gripper_right_finger_joint
- head_1_joint
- head_2_joint
position:
- -0.02799593211424245
- 0.003465789616476478
- -1.7199045996895583e-08
- -0.0005503061596039416
- -0.0003136661241898153
- -2.6876812497356184e-05
- -5.9248231679021046e-05
- 0.000129607204049087
- 0.0012243190113494506
- 0.0002718504386338694
- 2.561374795404651e-06
- 5.5824897165386553e-08
- -5.915678524814894e-07
- -0.0003185975886408343
velocity:
- .nan
- .nan
- -1.5386795985256052e-05
- 0.028547943684709375
- -0.05535369149489766
- 0.007545245983102342
- -0.0006098150419372589
- -0.031006116599605057
- 0.005376069634232324
- -0.015109590818687155
- -0.009228197094119775
- 0.012866053358847787
- 0.0035212422027661536
- -0.008785733629921097
effort:
- .nan
- .nan
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
---
```<hr>This is an automatic backport of pull request #1572 done by [Mergify](https://mergify.com).

(cherry picked from commit 364462a)

# Conflicts:
#	joint_state_broadcaster/src/joint_state_broadcaster.cpp
@mergify mergify bot added the conflicts label Apr 9, 2025
Copy link
Contributor Author

mergify bot commented Apr 9, 2025

Cherry-pick of 364462a has failed:

On branch mergify/bp/humble/pr-1572
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 364462a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   joint_state_broadcaster/doc/userdoc.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   joint_state_broadcaster/src/joint_state_broadcaster.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant