Skip to content

Improve steering controller tests #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Vedant87
Copy link
Contributor

@Vedant87 Vedant87 commented Apr 7, 2025

Closes #930

  • Converted the steering odometry tests to parameterized tests.
  • Added a new file for defining the parameterized test classes.
  • Introduced 2 parameterized test classes: 1) For regular test cases and 2) For steering limited test cases.

@Vedant87 Vedant87 marked this pull request as draft April 8, 2025 03:05
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 98.96907% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (460d67d) to head (e14a5c8).

Files with missing lines Patch % Lines
...ontrollers_library/test/test_steering_odometry.cpp 98.82% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
+ Coverage   84.79%   84.87%   +0.07%     
==========================================
  Files         127      128       +1     
  Lines       12114    12156      +42     
  Branches     1036     1054      +18     
==========================================
+ Hits        10272    10317      +45     
+ Misses       1503     1499       -4     
- Partials      339      340       +1     
Flag Coverage Δ
unittests 84.87% <98.96%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lers_library/test/test_steering_odometry_utils.hpp 100.00% <100.00%> (ø)
...ontrollers_library/test/test_steering_odometry.cpp 98.89% <98.82%> (-1.11%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vedant87 Vedant87 marked this pull request as ready for review April 8, 2025 03:40
@christophfroehlich
Copy link
Contributor

Thanks for your contribution, I try to come back with a review soon. Could you please review #1166 in the meantime? This should get merged soon.

@Vedant87
Copy link
Contributor Author

Thanks for your contribution, I try to come back with a review soon. Could you please review #1166 in the meantime? This should get merged soon.

Sure, I can help with reviewing #1166.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Steering Controller Tests
2 participants