-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the exported interface naming in the chainable controllers #1528
Fix the exported interface naming in the chainable controllers #1528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, and tested successfully with ros-controls/ros2_control_demos#710
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1528 +/- ##
==========================================
+ Coverage 84.50% 84.56% +0.05%
==========================================
Files 123 123
Lines 11295 11325 +30
Branches 948 950 +2
==========================================
+ Hits 9545 9577 +32
Misses 1446 1446
+ Partials 304 302 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
0d4b7e8
into
ros-controls:master
Fix the exported interfaces naming from the chainable controllers to have a proper standard interface name so that they can chain easily with other controllers without major changes.
Needs: ros-controls/ros2_control#2038