Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the exported interface naming in the chainable controllers #1528

Conversation

saikishor
Copy link
Member

Fix the exported interfaces naming from the chainable controllers to have a proper standard interface name so that they can chain easily with other controllers without major changes.

Needs: ros-controls/ros2_control#2038

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, and tested successfully with ros-controls/ros2_control_demos#710

Copy link
Contributor

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (6d681ef) to head (11149f6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
+ Coverage   84.50%   84.56%   +0.05%     
==========================================
  Files         123      123              
  Lines       11295    11325      +30     
  Branches      948      950       +2     
==========================================
+ Hits         9545     9577      +32     
  Misses       1446     1446              
+ Partials      304      302       -2     
Flag Coverage Δ
unittests 84.56% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.cpp 100.00% <100.00%> (ø)
...roller/test/test_ackermann_steering_controller.hpp 86.59% <ø> (ø)
.../test_ackermann_steering_controller_preceeding.cpp 100.00% <100.00%> (ø)
...dmittance_controller/src/admittance_controller.cpp 74.71% <100.00%> (ø)
...nce_controller/test/test_admittance_controller.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 83.11% <ø> (ø)
...st/test_bicycle_steering_controller_preceeding.cpp 100.00% <100.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 75.07% <100.00%> (+0.30%) ⬆️
...ive_controller/test/test_diff_drive_controller.cpp 94.29% <100.00%> (-0.02%) ⬇️
... and 14 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@christophfroehlich christophfroehlich merged commit 0d4b7e8 into ros-controls:master Feb 13, 2025
20 of 25 checks passed
@christophfroehlich christophfroehlich deleted the improve/chainable_export_interfaces_naming branch February 13, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants