Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std_msgs with example_interfaces #292

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Replace std_msgs with example_interfaces #292

wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 30, 2024

std_msgs was deprecated since Foxy ros2/examples#356 this PR replaces std_msgs with example_interfaces

@ahcorde
Replace std_msgs with example_interfaces
b4f061d 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Apr 30, 2024
christophfroehlich
christophfroehlich reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't realized yet that they are deprecated 😱 Don't we have to change that on ros2_controllers side first? I can do that in the next days..

@christophfroehlich
Copy link
Contributor

And to follow the intention of the deprecation, we should add "meaningful" messages to control_msgs first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich left review comments

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @christophfroehlich