-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LeadLag controller #60
Conversation
cfc9a91
to
2707516
Compare
This also partially addresses issue #35 |
|
7d41086
to
d1f205e
Compare
@bmagyar I just squashed all the commits into one. |
The latest commit refers to issue #61 (would have preferred to branch them out, but I guess it's a little bit too late now). |
Hello, Thanks for the pr! Some (very) minor notes about the documentation :)
Thanks again! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a bit of explanation & move this line into a separate commit if it's needed.
@@ -338,9 +338,6 @@ double Pid::getCurrentCmd() | |||
|
|||
void Pid::getCurrentPIDErrors(double *pe, double *ie, double *de) | |||
{ | |||
// Get the gain parameters from the realtime buffer | |||
Gains gains = *gains_buffer_.readFromRT(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops?
It's never not too late to branch it out. You can easily roll back your PR branch to the previous commit and make a force push. I'd merge the travis update on the separate PR. You should be able to change the Pull Request target to kinetic-devel. |
@progtologist Could you please rebase this PR against kinetic? Now we've got travis working again |
I will try to do it this weekend and update you ;) |
@progtologist this is a kind ping. I'd like to merge this, believe me :) |
I am closing this PR in favor of #68 (switched to kinetic, created separate feature branch to avoid polution if another fix emerges) |
This PR should be able to be integrated in any version(branch), I am currently using indigo so I have only tested it against that.