Update plugin lib exception handling

[Juliaj]

Address #257

@christophfroehlich , regarding to catch(...), I left it out since I am not sure what would be useful to log. I'm open to add it if you could provide some suggestions.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (e7049ab) to head (1ee9a9c).

Files with missing lines	Patch %	Lines
include/control_filters/exponential_filter.hpp	50.00%	2 Missing ⚠️
include/control_filters/low_pass_filter.hpp	50.00%	2 Missing ⚠️
include/control_filters/rate_limiter.hpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           ros2-master     #263      +/-   ##
===============================================
+ Coverage        74.81%   74.88%   +0.06%     
===============================================
  Files               24       24              
  Lines             1104     1107       +3     
  Branches            86       86              
===============================================
+ Hits               826      829       +3     
  Misses             231      231              
  Partials            47       47              

Flag	Coverage Δ
unittests	74.88% <64.70%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
test/control_filters/test_exponential_filter.cpp	100.00% <100.00%> (ø)
include/control_filters/exponential_filter.hpp	68.42% <50.00%> (+21.05%)	⬆️
include/control_filters/low_pass_filter.hpp	59.37% <50.00%> (-12.50%)	⬇️
include/control_filters/rate_limiter.hpp	73.07% <50.00%> (ø)

[christophfroehlich]

Thank you for your contribution!

Please fix the pre-commit issues (see the failing CI jobs). You can check that locally by pre-commit run --all, instructions for that you can find in the good first issue text or the contribution guidelines on control.ros.org

Regarding catch (...): I suggest adding a similar log like in the controller_manager?

[bmagyar]

Ah this is much nicer, thank you!

[saikishor]

Changes look good to me.

Just pre-commit fixes

[Juliaj]

@christophfroehlich , thanks for the pre-commit pointer. My bad, I didn't run it with --all. Fix made.

As for catch(...), thanks for sharing an example. The load_controller takes in two the input parameters which are logged as part of the catch all log statement. For our use case, the method configure() takes no parameter. I made an update to log a general statement. Feedback is appreciated.

[christophfroehlich]

Thanks!

[saikishor]

Looks great.
Thanks for adding tests!