Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visibility boilerplate code #258

Merged
merged 2 commits into from
Jan 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,16 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "(GNU|Clang)")
endif()

if(WIN32)
# Enable Math Constants
# https://docs.microsoft.com/en-us/cpp/c-runtime-library/math-constants?view=vs-2019
add_compile_definitions(
# For math constants
# https://docs.microsoft.com/en-us/cpp/c-runtime-library/math-constants?view=vs-2019
_USE_MATH_DEFINES
# Minimize Windows namespace collision
NOMINMAX
WIN32_LEAN_AND_MEAN
)
# set the same behavior for windows as it is on linux
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
endif()

set(THIS_PACKAGE_INCLUDE_DEPENDS
Expand Down
4 changes: 1 addition & 3 deletions include/control_toolbox/pid.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@

#include "realtime_tools/realtime_buffer.hpp"

#include "control_toolbox/visibility_control.hpp"

namespace control_toolbox
{
/***************************************************/
Expand Down Expand Up @@ -102,7 +100,7 @@ namespace control_toolbox
*/
/***************************************************/

class CONTROL_TOOLBOX_PUBLIC Pid
class Pid
{
public:
/*!
Expand Down
3 changes: 1 addition & 2 deletions include/control_toolbox/pid_ros.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,11 @@
#include "realtime_tools/realtime_publisher.hpp"

#include "control_toolbox/pid.hpp"
#include "control_toolbox/visibility_control.hpp"

namespace control_toolbox
{

class CONTROL_TOOLBOX_PUBLIC PidROS
class PidROS
{
public:
/*!
Expand Down
67 changes: 0 additions & 67 deletions include/control_toolbox/visibility_control.hpp

This file was deleted.

Loading