Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of DotNet.ReproducibleBuilds #137

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update to latest version of DotNet.ReproducibleBuilds #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35464ad
Update to latest version of DotNet.ReproducibleBuilds
MattKotsenas Jun 27, 2024
a1f04bf
Update Verify.Nupkg and ensure reproducible build branch
MattKotsenas Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/targets/reproducible/Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project>
<ItemGroup>
<PackageVersion Include="DotNet.ReproducibleBuilds" Version="1.1.1" />
<PackageVersion Include="DotNet.ReproducibleBuilds" Version="1.2.4" />
</ItemGroup>
</Project>
17 changes: 17 additions & 0 deletions build/targets/reproducible/Reproducible.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,19 @@
<Project>
<Target Name="SetRepositoryBranch" BeforeTargets="GenerateNuspec">
<!--
DotNet.ReproducibleBuilds tries to set the `$(RepositoryBranch)` for SourceLink, but only in CI scenarios.
This results in a difference in nuspec between local and CI tests (which breaks the Verify.Nupkg tests).

To prevent the difference in behavior, set a default value directly from git.

Filed https://github.com/dotnet/sourcelink/issues/1243 to see if this could be moved into the base SourceLink
package.
-->
<Exec
Condition="'$(RepositoryBranch)' == ''"
ConsoleToMSBuild="true"
Command="git rev-parse --abbrev-ref HEAD">
<Output TaskParameter="ConsoleOutput" PropertyName="RepositoryBranch" />
</Exec>
</Target>
</Project>
2 changes: 1 addition & 1 deletion build/targets/tests/Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PackageVersion Include="ReportGenerator" Version="5.3.6" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="1.1.2-beta1.24314.1" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageVersion Include="Verify.Nupkg" Version="1.1.5" />
<PackageVersion Include="Verify.Nupkg" Version="1.1.6" />
<PackageVersion Include="Verify.Xunit" Version="25.0.4" />
<PackageVersion Include="xunit" Version="2.8.1" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.1" />
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"rollForward": "latestFeature"
},
"msbuild-sdks": {
"DotNet.ReproducibleBuilds.Isolated": "1.1.1"
"DotNet.ReproducibleBuilds.Isolated": "1.2.4"
}
}
2 changes: 1 addition & 1 deletion tests/Moq.Analyzers.Test/PackageTests.Baseline#manifest.verified.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
<releaseNotes>A changelog is available at https://github.com/rjmurillo/moq.analyzers/releases</releaseNotes>
<copyright>2017 Andrey Lipatkin</copyright>
<tags>moq, tdd, mocking, mocks, unittesting, agile, unittest, mock, test, analyzers</tags>
<repository type="git" url="https://github.com/********/moq.analyzers.git" commit="****************************************" />
<repository type="git" url="https://github.com/********/moq.analyzers.git" branch="********" commit="****************************************" />
</metadata>
</package>