Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of DotNet.ReproducibleBuilds #137

Merged

Conversation

MattKotsenas
Copy link
Collaborator

@MattKotsenas MattKotsenas commented Jun 27, 2024

Update to the latest version of DotNet.ReproducibleBuilds. Doing so exposes a difference in how SourceLink is invoked between local and CI scenarios. I make local build work like CI by adding a RepositoryBranch if one isn't supplied (bug filed against the SourceLink repo to do the fallback directly). This then requires pulling in a newer version of Verify.Nupkg in order to scrub the new branch attribute.

@MattKotsenas MattKotsenas requested a review from rjmurillo June 27, 2024 22:34
@rjmurillo rjmurillo added dependencies Pull requests that update a dependency file releasable build labels Jun 27, 2024
@MattKotsenas MattKotsenas enabled auto-merge (squash) June 27, 2024 22:34
@MattKotsenas MattKotsenas force-pushed the refactor/reproducible-builds-upgrade branch from db621e7 to 86d099d Compare June 27, 2024 22:34
@MattKotsenas MattKotsenas force-pushed the refactor/reproducible-builds-upgrade branch from 86d099d to 7285757 Compare June 28, 2024 00:26
@MattKotsenas MattKotsenas force-pushed the refactor/reproducible-builds-upgrade branch from 7285757 to a1f04bf Compare June 28, 2024 00:29
@MattKotsenas MattKotsenas merged commit 39e45bc into rjmurillo:main Jun 28, 2024
5 checks passed
@rjmurillo rjmurillo added this to the vNext milestone Jun 28, 2024
@MattKotsenas MattKotsenas deleted the refactor/reproducible-builds-upgrade branch June 28, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file releasable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants