Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): reorganize file connector CI tests #19230

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Nov 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The previous tests for file source and file sink were quite complicated. This PR reorganized them and put all the functional and correctness tests together.

  • file_source.py: test streaming source on json and csv encode, batch read from file source and handling incremental files.
  • file_sink.pr: test sink into file system in both parquet and json encode, and test the batching strategy.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu marked this pull request as draft November 1, 2024 08:14
@wcy-fdu wcy-fdu marked this pull request as ready for review November 3, 2024 09:45
@graphite-app graphite-app bot requested a review from a team November 3, 2024 10:29
@wcy-fdu wcy-fdu requested a review from tabVersion November 4, 2024 05:32
@wcy-fdu wcy-fdu added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit f3e9a3b Nov 4, 2024
39 of 40 checks passed
@wcy-fdu wcy-fdu deleted the wcy/refactor_file_connector_test.pr branch November 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants