Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick feat(connector): support more parquet data types (#19561) to branch release-2.0 #19602

Closed
wants to merge 10 commits into from

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Nov 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Since it will take some time for us to release 2.1, several recent fixes about parquet data type need to be delivered to customers. This PR cherry-picks these fixes into release 2.0 in order of dependencies.

Cherry picked changes and order(Due to dependencies, cherry picking only two fixes will result in more conflicts.):

  1. column pruning for parquet data type feat(source): column pruning for parquet file source #18967
  2. test reorganization refactor(test): reorganize file connector CI tests #19230
  3. fix on timestamp type refactor(source): enhance parquet file source #19221
  4. tvf and parquet source common logic refactor(connector): extract the common logic of file_scan tvf and parquet source #19398
  5. Uint datatype feat(connector): support more parquet data types #19561

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Nov 28, 2024

Not sure if we will release 2.0.4, I will first package an based on the branch of this PR. This PR can be merged on demand. cc @lmatz

@graphite-app graphite-app bot requested a review from lmatz November 28, 2024 12:27
Copy link

graphite-app bot commented Nov 28, 2024

Graphite Automations

"release branch request review" took an action on this PR • (11/28/24)

1 reviewer was added to this PR based on xxchan's automation.

@lmatz
Copy link
Contributor

lmatz commented Nov 28, 2024

tests failed

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Nov 28, 2024

tests failed

I see, I'm working on fixing it, and this pr do not need to merge into release-2.0. Open it to run CI.

@wcy-fdu wcy-fdu closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants