Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: clean up some code around AnacondaWizard component #5248

Merged
merged 5 commits into from
Oct 16, 2023
Merged

webui: clean up some code around AnacondaWizard component #5248

merged 5 commits into from
Oct 16, 2023

Commits on Oct 13, 2023

  1. webui: pass the properties only to the components that use these

    @KKoukiou
    KKoukiou committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    252ca0e View commit details
    Browse the repository at this point in the history

  2. webui: sort some state variables alphabetically

    @KKoukiou
    KKoukiou committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    234eb86 View commit details
    Browse the repository at this point in the history

  3. webui: let's be consistent on how we hide steps 

    Reuse the isHidden existing logic instead of doing this with the spread
operator and conditional.
    @KKoukiou
    KKoukiou committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    32c3fbd View commit details
    Browse the repository at this point in the history

  4. webui: Drop global notifications in favor of the per page notifications 

    For the Web UI we need to keep three exception notifications types:

* Critical Error; this opens the 'Report' modal and blocks the
installation. It must be used for unexpected Exceptions from the
Backend, for example when fetching state data.

* Per page notifications; these should be created as a result of
submission of some configuration which is not accepted by the backend; the user
should be able to react to the error by changing their choices.

* Inline errors; these are feedback to the user from cheap sanity checks
for the validity of the forms.

The dropped 'onAddErrorNotification' method was adding `Toast Alerts` centrally on
the app, which does not fall under any of these categories. Replace the
two occurances of its usage with the per-page notifications.

Additionally keep the functionality of displaying per-page notifications
in the AnacondaPage component so that the code can be shared between all
pages.
    @KKoukiou
    KKoukiou committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    a6080aa View commit details
    Browse the repository at this point in the history

  5. webui: move per-page title, id, label and hidden state into the compo… 

    …nents

In order to cleanup a bit the AnacondaWizard from keeping the per-step
knowledge.
    @KKoukiou
    KKoukiou committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ffee48d View commit details
    Browse the repository at this point in the history