webui: clean up some code around AnacondaWizard component #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the isHidden existing logic instead of doing this with the spread operator and conditional.
For the Web UI we need to keep three exception notifications types: * Critical Error; this opens the 'Report' modal and blocks the installation. It must be used for unexpected Exceptions from the Backend, for example when fetching state data. * Per page notifications; these should be created as a result of submission of some configuration which is not accepted by the backend; the user should be able to react to the error by changing their choices. * Inline errors; these are feedback to the user from cheap sanity checks for the validity of the forms. The dropped 'onAddErrorNotification' method was adding `Toast Alerts` centrally on the app, which does not fall under any of these categories. Replace the two occurances of its usage with the per-page notifications. Additionally keep the functionality of displaying per-page notifications in the AnacondaPage component so that the code can be shared between all pages.
…nents In order to cleanup a bit the AnacondaWizard from keeping the per-step knowledge.
rvykydal
approved these changes
Oct 16, 2023
|
/kickstart-test --waive webui only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.