-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: clean up logic for repositories in various test scenarios #75
Conversation
6101fa4
to
81f80b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see anything obviously wrong, but TBH it's hard to follow what happens here. So if you are in a hurry and want to get unblocked, go ahead.
81f80b6
to
dcc637c
Compare
QR code is missing, but this feels like a flake. Retrying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks! Let's see if the retry is happy.
# but it packs to many packages to updates.img | ||
missing_packages_incl_deps = "firefox" | ||
|
||
from machine.machine_core import machine_virtual # NOQA: imported through parent.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, there is no parent.py
any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for heads up! Will clean it up in followup
* Always pull anaconda-core from COPR build from master branch, previously it was happening only if TEST_SCENARIO was not empty (fix for 082c360) * Add scenario for anaconda-webui PR * Rename build-rpms to vm.install as the RPMs even for anaconda-webui are conditionally built Document all options better.
dcc637c
to
22bee6e
Compare
@martinpitt these were wrongly submitted pixel test reference from an unmerged PR ;) removed! |
Document all options better.