Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: clean up logic for repositories in various test scenarios #75

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Dec 1, 2023

  • Always pull anaconda-core from COPR build from master branch, previously it was happening only if TEST_SCENARIO was not empty (fix for 082c360)
  • Add scenario for anaconda-webui PR

Document all options better.

@KKoukiou KKoukiou force-pushed the run-anaconda-master-fixup branch 2 times, most recently from 6101fa4 to 81f80b6 Compare December 1, 2023 18:42
@KKoukiou KKoukiou requested a review from martinpitt December 1, 2023 19:37
Copy link
Collaborator

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see anything obviously wrong, but TBH it's hard to follow what happens here. So if you are in a hurry and want to get unblocked, go ahead.

@KKoukiou KKoukiou force-pushed the run-anaconda-master-fixup branch from 81f80b6 to dcc637c Compare December 4, 2023 14:06
@martinpitt
Copy link
Collaborator

QR code is missing, but this feels like a flake. Retrying.

Copy link
Collaborator

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks! Let's see if the retry is happy.

# but it packs to many packages to updates.img
missing_packages_incl_deps = "firefox"

from machine.machine_core import machine_virtual # NOQA: imported through parent.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, there is no parent.py any more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for heads up! Will clean it up in followup

* Always pull anaconda-core from COPR build from master branch,
  previously it was happening only if TEST_SCENARIO was not empty
  (fix for 082c360)
* Add scenario for anaconda-webui PR

* Rename build-rpms to vm.install as the RPMs even for anaconda-webui
are conditionally built

Document all options better.
@KKoukiou KKoukiou force-pushed the run-anaconda-master-fixup branch from dcc637c to 22bee6e Compare December 5, 2023 07:40
@KKoukiou
Copy link
Contributor Author

KKoukiou commented Dec 5, 2023

QR code is missing, but this feels like a flake. Retrying.

@martinpitt these were wrongly submitted pixel test reference from an unmerged PR ;) removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants