Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce fedora eln image and ISO for anaconda #5585

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Introduce fedora eln image and ISO for anaconda #5585

merged 5 commits into from
Dec 6, 2023

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Nov 23, 2023 •
edited by martinpitt
Loading

Image refresh for fedora-eln-boot

  • image-refresh fedora-eln-boot
  • image-refresh fedora-eln
  • image-refresh fedora-39

Being used in rhinstaller/anaconda-webui#70

@KKoukiou KKoukiou added the bot label Nov 23, 2023
@cockpituous cockpituous changed the title Introduce anaconda fedora eln image WIP: 4-ci-srv-03: [no-test] Introduce anaconda fedora eln image Nov 23, 2023
@cockpituous
Copy link
Contributor

image-refresh fedora-eln-boot done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-eln-boot-20231123-130843

@cockpituous cockpituous changed the title WIP: 4-ci-srv-03: [no-test] Introduce anaconda fedora eln image Introduce anaconda fedora eln image Nov 23, 2023
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/fedora-eln-boot-20231123-130808.log

KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Nov 23, 2023
@KKoukiou
tests: allow overriding the OS
9aca845 
We want to start testing webui against fedora ELN cockpit-project/bots#5585
@KKoukiou KKoukiou mentioned this pull request Nov 23, 2023
Merged
@KKoukiou
Copy link
Contributor Author

Tests are still running on rawhide. Needs rhinstaller/anaconda-webui#63

@jkonecny12
Copy link
Contributor

jkonecny12 commented Nov 24, 2023 •
edited
Loading

Hi, @sgallagher, FYI this might be interesting to you.
We will start testing on ELN for Anaconda web UI.

@KKoukiou KKoukiou marked this pull request as draft November 24, 2023 16:17
@KKoukiou
Copy link
Contributor Author

This is now blocked on https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/674

@KKoukiou KKoukiou removed the bot label Nov 24, 2023
@KKoukiou KKoukiou force-pushed the introduce-anaconda-fedora-eln-image branch from c5ae81d to 88376a8 Compare November 24, 2023 17:06
@KKoukiou KKoukiou changed the title Introduce anaconda fedora eln image Introduce fedora eln image and ISO for anaconda Nov 24, 2023
@KKoukiou KKoukiou added the bot label Nov 24, 2023
@cockpituous cockpituous changed the title Introduce fedora eln image and ISO for anaconda WIP: 4-cockpit-10: [no-test] Introduce fedora eln image and ISO for anaconda Nov 24, 2023
@cockpituous
Copy link
Contributor

image-refresh fedora-eln-boot done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-eln-boot-20231124-171612

@cockpituous cockpituous changed the title WIP: 4-cockpit-10: [no-test] Introduce fedora eln image and ISO for anaconda Introduce fedora eln image and ISO for anaconda Nov 24, 2023
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/fedora-eln-boot-20231124-171616.log

@cockpituous cockpituous changed the title Introduce fedora eln image and ISO for anaconda WIP: rhos-01-10: [no-test] Introduce fedora eln image and ISO for anaconda Nov 24, 2023
@KKoukiou KKoukiou force-pushed the introduce-anaconda-fedora-eln-image branch from 88376a8 to 30b7665 Compare November 24, 2023 17:20
@cockpituous
Copy link
Contributor

image-refresh fedora-eln done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-eln-20231124-172055

@cockpituous cockpituous changed the title WIP: rhos-01-10: [no-test] Introduce fedora eln image and ISO for anaconda Introduce fedora eln image and ISO for anaconda Nov 24, 2023
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/fedora-eln-20231124-172020.log

@KKoukiou KKoukiou force-pushed the introduce-anaconda-fedora-eln-image branch from 30b7665 to dfd753a Compare November 24, 2023 17:25
martinpitt
martinpitt requested changes Nov 25, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Setting the blocked label as per your comment above.

@cockpituous cockpituous changed the title Introduce fedora eln image and ISO for anaconda WIP: 4-ci-srv-04: [no-test] Introduce fedora eln image and ISO for anaconda Nov 27, 2023
@cockpituous cockpituous changed the title WIP: 4-ci-srv-04: [no-test] Introduce fedora eln image and ISO for anaconda Introduce fedora eln image and ISO for anaconda Nov 27, 2023
@cockpituous
Copy link
Contributor

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/fedora-eln-20231127-102121.log

@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/fedora-eln-20231201-112626.log

@KKoukiou KKoukiou force-pushed the introduce-anaconda-fedora-eln-image branch from 099001c to e17da9f Compare December 1, 2023 19:13
@martinpitt
Copy link
Member

that failure should be fixed by rhinstaller/anaconda-webui#75 , retrying

@martinpitt martinpitt force-pushed the introduce-anaconda-fedora-eln-image branch from e17da9f to 3a06f5b Compare December 5, 2023 11:51
@martinpitt
Copy link
Member

I rebased this, as the previous version had outdated images

martinpitt
martinpitt previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. As this doesn't break anything, I'm happy to land this even though rhinstaller/anaconda-webui#70 isn't ready yet. This keeps getting stale, so please either land it now, or (if it's too broken and not relevant), let's shelve it.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Dec 5, 2023

It's relevant - I just was hoping to get at least a semi-successful test run before merging.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Dec 5, 2023

Now it fails again with some other error, I will check

@cockpituous cockpituous changed the title Introduce fedora eln image and ISO for anaconda WIP: rhos-01-19: [no-test] Introduce fedora eln image and ISO for anaconda Dec 5, 2023
@cockpituous
Copy link
Contributor

image-refresh fedora-eln-boot done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-eln-boot-20231205-130136

@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/fedora-eln-boot-20231205-130101.log

@cockpituous cockpituous changed the title WIP: rhos-01-19: [no-test] Introduce fedora eln image and ISO for anaconda Introduce fedora eln image and ISO for anaconda Dec 5, 2023
@cockpituous cockpituous changed the title Introduce fedora eln image and ISO for anaconda WIP: rhos-01-19: [no-test] Introduce fedora eln image and ISO for anaconda Dec 5, 2023
@cockpituous
Copy link
Contributor

image-refresh fedora-eln done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-eln-20231205-131831

@cockpituous cockpituous changed the title WIP: rhos-01-19: [no-test] Introduce fedora eln image and ISO for anaconda Introduce fedora eln image and ISO for anaconda Dec 5, 2023
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/fedora-eln-20231205-131818.log

@KKoukiou KKoukiou force-pushed the introduce-anaconda-fedora-eln-image branch from 3a06f5b to 3253df6 Compare December 5, 2023 13:27
@KKoukiou KKoukiou force-pushed the introduce-anaconda-fedora-eln-image branch from 3253df6 to 31ba6d6 Compare December 5, 2023 13:47
@KKoukiou KKoukiou requested a review from martinpitt December 5, 2023 14:20
martinpitt
martinpitt approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I am trying to reproduce the -boot image failures locally. Unfortunately that image doesn't set up a serial console, so virsh console doesn't work, and thus we cannot capture/log boot failures.

I'll see what's going on with virt-viewer, once I get a boot failure locally.

Update: Continuing this in rhinstaller/anaconda-webui#70 (comment)

@martinpitt
Copy link
Member

I land this now. The fedora-eln image works reasonably well, and the -boot image is just a simple curl anyway, no modifications. So if it's broken, it needs to be fixed in Fedora. It could also be that it requires different QEMU options on our side, I'll debug that this morning in rhinstaller/anaconda-webui#70

@martinpitt martinpitt merged commit 5c2b0a8 into cockpit-project:main Dec 6, 2023
velezd pushed a commit to velezd/anaconda-webui that referenced this pull request Dec 12, 2023
@KKoukiou @velezd
tests: allow overriding the OS
e6795f6 
We want to start testing webui against fedora ELN cockpit-project/bots#5585
jelly pushed a commit to jelly/anaconda-webui that referenced this pull request May 28, 2024
@KKoukiou @jelly
tests: allow overriding the OS
59eb41b 
We want to start testing webui against fedora ELN cockpit-project/bots#5585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KKoukiou @cockpituous @jkonecny12 @sgallagher @martinpitt