-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-93073 migrate to Spring Boot 3 #14
Open
grabsefx
wants to merge
7
commits into
develop
Choose a base branch
from
EPMRPP-93073-JDK21
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+627
−1,002
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eecfc95
EPMRPP-93073 migrate to JDK21
grabsefx a1ef860
Merge branch 'refs/heads/develop' into EPMRPP-93073-JDK21
grabsefx aa5a5c9
EPMRPP-93073 support Spring Boot 3
grabsefx b997ee3
EPMRPP-93073 support Spring Boot 3
grabsefx 4ed74a1
EPMRPP-93073 support Spring Boot 3
grabsefx 6ee6185
Merge branch 'develop' into EPMRPP-93073-SpringBoot-3-support
grabsefx 6369bc5
EPMRPP-93073 dependency updates
grabsefx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,4 +105,4 @@ jobs: | |
else | ||
echo 'Verification failed, please check the bundle' 1>&2 | ||
exit 1 | ||
fi | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
version=5.13.0 | ||
|
||
org.gradle.parallel=true | ||
org.gradle.caching=true | ||
|
||
description=EPAM Report portal. REST Reporting API model | ||
hibernateValidatorVersion=6.1.2.Final | ||
validationApiVersion=2.0.1.Final | ||
junitVersion=4.12 | ||
jupiterVersion=5.8.1 | ||
elApiVersion=3.0.0 | ||
sprindocAnnotationsVersion=1.7.0 | ||
commonsLangVersion=3.9 | ||
mockitoJunitJupiter=3.4.6 | ||
jacksonVersion=2.10.2 | ||
lombokVersion=1.18.30 | ||
hibernateValidatorVersion=8.0.2.Final | ||
junitVersion=5.11.4 | ||
mockitoJunitJupiter=5.14.2 | ||
springDocVersion=2.7.0 | ||
commonsLangVersion=3.17.0 | ||
jacksonVersion=2.18.2 | ||
lombokVersion=1.18.36 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
jdk: | ||
- openjdk21 | ||
- openjdk21 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,34 +16,34 @@ | |
|
||
package com.epam.ta.reportportal.ws.annotations; | ||
|
||
import javax.validation.ConstraintValidator; | ||
import javax.validation.ConstraintValidatorContext; | ||
import java.util.ArrayList; | ||
import jakarta.validation.ConstraintValidator; | ||
import jakarta.validation.ConstraintValidatorContext; | ||
import java.util.Arrays; | ||
import java.util.Collection; | ||
import java.util.List; | ||
import java.util.Set; | ||
import java.util.stream.Collectors; | ||
|
||
/** | ||
* @author <a href="mailto:[email protected]">Ihar Kahadouski</a> | ||
*/ | ||
public class InCollectionValidator implements ConstraintValidator<In, Collection<String>> { | ||
|
||
private String[] allowedValues; | ||
private Set<String> allowedValues; | ||
|
||
@Override | ||
public void initialize(In constraintAnnotation) { | ||
allowedValues = new String[constraintAnnotation.allowedValues().length]; | ||
for (int i = 0; i < constraintAnnotation.allowedValues().length; i++) { | ||
allowedValues[i] = constraintAnnotation.allowedValues()[i].toUpperCase(); | ||
} | ||
allowedValues = Arrays.stream(constraintAnnotation.allowedValues()) | ||
.map(String::toUpperCase) | ||
.collect(Collectors.toSet()); | ||
} | ||
|
||
@Override | ||
public boolean isValid(Collection<String> value, ConstraintValidatorContext context) { | ||
List<String> upperCaseList = new ArrayList<>(); | ||
for (String next : value) { | ||
upperCaseList.add(next.toUpperCase()); | ||
} | ||
return Arrays.asList(allowedValues).containsAll(upperCaseList); | ||
List<String> upperCaseList = value.stream() | ||
.map(String::toUpperCase) | ||
.toList(); | ||
|
||
return allowedValues.containsAll(upperCaseList); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,8 +16,8 @@ | |
|
||
package com.epam.ta.reportportal.ws.annotations; | ||
|
||
import javax.validation.ConstraintValidator; | ||
import javax.validation.ConstraintValidatorContext; | ||
import jakarta.validation.ConstraintValidator; | ||
import jakarta.validation.ConstraintValidatorContext; | ||
|
||
/** | ||
* @author <a href="mailto:[email protected]">Ihar Kahadouski</a> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,13 +17,17 @@ | |
package com.epam.ta.reportportal.ws.reporting; | ||
|
||
import java.util.List; | ||
import javax.validation.Valid; | ||
import javax.validation.constraints.NotNull; | ||
import javax.validation.constraints.Size; | ||
import jakarta.validation.Valid; | ||
import jakarta.validation.constraints.NotNull; | ||
import jakarta.validation.constraints.Size; | ||
import lombok.Getter; | ||
import lombok.Setter; | ||
|
||
/** | ||
* @author <a href="mailto:[email protected]">Ihar Kahadouski</a> | ||
*/ | ||
@Setter | ||
@Getter | ||
public class BulkInfoUpdateRQ { | ||
|
||
@NotNull | ||
|
@@ -35,56 +39,19 @@ public class BulkInfoUpdateRQ { | |
@Valid | ||
private List<UpdateItemAttributeRQ> attributes; | ||
|
||
public List<Long> getIds() { | ||
return ids; | ||
} | ||
|
||
public void setIds(List<Long> ids) { | ||
this.ids = ids; | ||
} | ||
|
||
public Description getDescription() { | ||
return description; | ||
} | ||
|
||
public void setDescription(Description description) { | ||
this.description = description; | ||
} | ||
|
||
public List<UpdateItemAttributeRQ> getAttributes() { | ||
return attributes; | ||
} | ||
|
||
public void setAttributes(List<UpdateItemAttributeRQ> attributes) { | ||
this.attributes = attributes; | ||
} | ||
|
||
public enum Action { | ||
public enum Action { | ||
DELETE, | ||
UPDATE, | ||
CREATE | ||
} | ||
|
||
public static class Description { | ||
@Setter | ||
@Getter | ||
public static class Description { | ||
|
||
String comment; | ||
|
||
Action action; | ||
|
||
public String getComment() { | ||
return comment; | ||
} | ||
|
||
public void setComment(String comment) { | ||
this.comment = comment; | ||
} | ||
|
||
public Action getAction() { | ||
return action; | ||
} | ||
|
||
public void setAction(Action action) { | ||
this.action = action; | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration to JDK 21 shifts potential usage of this library to unknown future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the project already migrated to JDK 21
https://github.com/reportportal/commons-reporting/blob/develop/build.gradle#L38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that I missed this, is not an excuse.