EPMRPP-93073 migrate to Spring Boot 3 #14
Conversation
grabsefx
commented
Nov 7, 2024
•
grabsefx
commented
- gradle 8.12
- latest libraries versions
- junit 5
- spring doc 2.7.0
- jakarta EE
- lombok
# Conflicts: # build.gradle # gradle.properties # gradle/wrapper/gradle-wrapper.properties # jitpack.yml # src/main/java/com/epam/ta/reportportal/ws/reporting/LaunchResource.java
grabsefx
changed the title
# Conflicts: # gradle.properties # src/test/java/com/epam/ta/reportportal/ws/reporting/serializers/OffsetDateTimeInstantSerializerTest.java
| - openjdk21 |
There was a problem hiding this comment.
Migration to JDK 21 shifts potential usage of this library to unknown future.
There was a problem hiding this comment.
the project already migrated to JDK 21
https://github.com/reportportal/commons-reporting/blob/develop/build.gradle#L38
There was a problem hiding this comment.
The fact that I missed this, is not an excuse.
build.gradle
Outdated
| implementation "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}" | ||
| implementation "javax.validation:validation-api:${validationApiVersion}" | ||
| implementation "org.apache.commons:commons-lang3:${commonsLangVersion}" | ||
| api "org.springdoc:springdoc-openapi-starter-common:${springDocVersion}" |
There was a problem hiding this comment.
I didn't manage to find any single reference on Spring in the code. If don use this library only to include transient Swagger annotations, please remove it and include swagger-annotations directly.
build.gradle
Outdated
| implementation "javax.validation:validation-api:${validationApiVersion}" | ||
| implementation "org.apache.commons:commons-lang3:${commonsLangVersion}" | ||
| api "org.springdoc:springdoc-openapi-starter-common:${springDocVersion}" | ||
| api "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}" |
There was a problem hiding this comment.
We don't want our users rely on jackson version specified by our library, since we want to be free changing it. Please revert to implementation.
build.gradle
Outdated
| api "org.hibernate.validator:hibernate-validator:${hibernateValidatorVersion}" | ||
| api "org.apache.commons:commons-lang3:${commonsLangVersion}" | ||
| api "com.fasterxml.jackson.datatype:jackson-datatype-jsr310:${jacksonVersion}" |
