Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solana sign and send transaction #664

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Aug 2, 2024

Description

This PR is adding signAndSendTransaction for Solana wallet by listening to solana_signAndSendTransaction RPC call.

Screen.Recording.2024-08-02.at.18.32.46.mov

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-react-ethersv5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 1:45pm
decentralized-relay-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 1:45pm
react-wallet-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 1:45pm
vue-web-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 1:45pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
decentralized-relay-app ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
malicious-dapp-verify-simulation ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
react-auth-dapp ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
react-auth-wallet ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
react-dapp-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
svelte-web3modal ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm
vue-dapp-auth ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 1:45pm

}))
const programId = new PublicKey(instruction.programId)
const data = (() => {
if (typeof instruction.data === 'undefined') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, good catch, thanks

@tomiir tomiir requested a review from glitch-txs August 6, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants