refactor: solana sign and send transaction #2646
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
eGetting the following error while calling s.signAndSendTransaction is not a functionSteps to repro:
The |
… options in base connector signature
Good catch @enesozturk, thanks! I have added it with c741a8e Screen.Recording.2024-08-05.at.15.17.10.mov |
…or/solana-sign-and-send-transaction
…or/solana-sign-and-send-transaction
…or/solana-sign-and-send-transaction
| <Heading size="xs" textTransform="uppercase" pb="2"> | ||
| Sign and Send Transaction | ||
| Sign and Send Transaction (dApp) | ||
| </Heading> | ||
| <SolanaSendTransactionTest /> | ||
| </Box> | ||
| <Box> | ||
| <Heading size="xs" textTransform="uppercase" pb="2"> | ||
| Sign and Send Transaction (Wallet) | ||
| </Heading> | ||
| <SolanaSignAndSendTransaction /> | ||
| </Box> |
There was a problem hiding this comment.
What is the difference between Dapp and Wallet?
There was a problem hiding this comment.
Dapp: the dapp request to wallet sign transaction and sends to blockchain
Wallet: the dapp request to wallet sign and send the transaction
There was a problem hiding this comment.
Hmm I feel this is confusing, so you are doing basically
Request wallet to sign transaction => Manually send it from lab
Request wallet to sign and send transaction directly
Why send the tx from lab in the first place? isn't just requesting the signing enough?
Just a nit tho
There was a problem hiding this comment.
There is the two ways of doing it and both are valid: the first case is testing the signTransaction and sendTransaction functions, the second is testing signAndSendTransaction which sends for wallet handle the blockchain connection.
|
Could sign a versioned tx with Phantom, but not a regular tx |
Description
This PR changes the logic for Solana WalletConnect connector to send the transaction for the wallet to sign and send instead of sending in the dapp. It goes alongside with reown-com/web-examples#664.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
Screen.Recording.2024-08-02.at.18.32.46.mov
Checklist