Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): match on devDependencies or dev for dev dependencies-related presets #33909

Merged
merged 7 commits into from
Jan 30, 2025
Merged

fix(presets): match on devDependencies or dev for dev dependencies-related presets #33909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95738df
fix(presets): match on devDependencies or dev for dev dependencies-re…
alsyia Jan 29, 2025
0dc9ede
chore: apply suggestions from code review
alsyia Jan 29, 2025
06c0b69
fix(presets): also add 'dev-dependencies' to the list of matching dep…
alsyia Jan 29, 2025
1507ca2
chore: apply suggestions from code review
alsyia Jan 29, 2025
a965dfc
Merge branch 'main' into fix/include-dev-dependencies-in-presets
alsyia Jan 29, 2025
ea7fc18
chore(presets): update snapshot for presets/index.spec.ts
alsyia Jan 30, 2025
38d04b1
Merge branch 'main' into fix/include-dev-dependencies-in-presets
alsyia Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/config/presets/__snapshots__/index.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] =
"Add the \`renovate/\` prefix to all branch names.",
"Use semantic commit type \`fix\` for dependencies and \`chore\` for all others if semantic commits are in use.",
"Require all status checks to pass before any automerging.",
"Pin dependency versions for \`devDependencies\` and retain SemVer ranges for others.",
"Pin dependency versions for development dependencies and retain SemVer ranges for others.",
],
"ignoreTests": false,
"ignoreUnstable": true,
Expand Down Expand Up @@ -111,6 +111,8 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] =
{
"matchDepTypes": [
"devDependencies",
"dev-dependencies",
"dev",
],
"rangeStrategy": "pin",
},
Expand Down
12 changes: 6 additions & 6 deletions lib/config/presets/internal/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ export const presets: Record<string, Preset> = {
description: 'Disable Renovate Dependency Dashboard creation.',
},
disableDevDependencies: {
description: 'Do not update `devDependencies` versions/ranges.',
description: 'Do not update development dependencies.',
packageRules: [
{
enabled: false,
matchDepTypes: ['devDependencies'],
matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'],
},
],
},
Expand Down Expand Up @@ -408,10 +408,10 @@ export const presets: Record<string, Preset> = {
],
},
pinDevDependencies: {
description: 'Pin dependency versions for `devDependencies`.',
description: 'Pin dependency versions for development dependencies.',
packageRules: [
{
matchDepTypes: ['devDependencies'],
matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'],
rangeStrategy: 'pin',
},
],
Expand All @@ -422,14 +422,14 @@ export const presets: Record<string, Preset> = {
},
pinOnlyDevDependencies: {
description:
'Pin dependency versions for `devDependencies` and retain SemVer ranges for others.',
'Pin dependency versions for development dependencies and retain SemVer ranges for others.',
packageRules: [
{
matchPackageNames: ['*'],
rangeStrategy: 'replace',
},
{
matchDepTypes: ['devDependencies'],
matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'],
rangeStrategy: 'pin',
},
{
Expand Down
Loading