-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(presets): match on devDependencies or dev for dev dependencies-related presets #33909
fix(presets): match on devDependencies or dev for dev dependencies-related presets #33909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't dev-dependencies
the depType identified in the related discussion? This PR adds only dev
Co-authored-by: Rhys Arkins <[email protected]>
Co-authored-by: Rhys Arkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs snapshot update
Head branch was pushed to by a user without write access
Done! |
🎉 This PR is included in version 39.145.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This PR implements a change discussed in this [discussion item][https://github.com//discussions/33897).
Renovate has some presets to pin development dependencies, but the underlying rules only match on
devDependencies
. Some managers, like Poetry, tag their development dependencies withdev
ordev-dependencies
. The PR adds thedev
tag in development dependencies related rules.Note: depending on the version of Poetry, the value can be either
dev-dependencies
(older) ordev
. For now, I've added onlydev
as it seems this is the way going forward with Poetry dependencies groups.Context
See the related discussion. People expect the dev related presets to pin dev dependencies across all language, but currently Poetry dev dependencies aren't included.
Documentation (please check one with an [x])
I didn't find documentation related to this preset in the repo.
How I've tested my work (please select one)
I have verified these changes via:
You can see the real repo here: https://github.com/alsyia/renovate-test/pull/2/files