Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): match on devDependencies or dev for dev dependencies-related presets #33909

Merged

Conversation

alsyia
Copy link
Contributor

@alsyia alsyia commented Jan 29, 2025

Changes

This PR implements a change discussed in this [discussion item][https://github.com//discussions/33897).

Renovate has some presets to pin development dependencies, but the underlying rules only match on devDependencies. Some managers, like Poetry, tag their development dependencies with dev or dev-dependencies. The PR adds the dev tag in development dependencies related rules.

Note: depending on the version of Poetry, the value can be either dev-dependencies (older) or dev. For now, I've added only dev as it seems this is the way going forward with Poetry dependencies groups.

Context

See the related discussion. People expect the dev related presets to pin dev dependencies across all language, but currently Poetry dev dependencies aren't included.

Documentation (please check one with an [x])

I didn't find documentation related to this preset in the repo.

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

You can see the real repo here: https://github.com/alsyia/renovate-test/pull/2/files

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@alsyia alsyia changed the title Match on devDependencies or dev for dev dependencies-related presets fix(presets): match on devDependencies or dev for dev dependencies-related presets Jan 29, 2025
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't dev-dependencies the depType identified in the related discussion? This PR adds only dev

lib/config/presets/internal/default.ts Outdated Show resolved Hide resolved
lib/config/presets/internal/default.ts Outdated Show resolved Hide resolved
lib/config/presets/internal/default.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jan 29, 2025
@rarkins rarkins enabled auto-merge January 29, 2025 14:19
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs snapshot update

auto-merge was automatically disabled January 30, 2025 09:31

Head branch was pushed to by a user without write access

@alsyia
Copy link
Contributor Author

alsyia commented Jan 30, 2025

needs snapshot update

Done!

@rarkins rarkins enabled auto-merge January 30, 2025 15:56
@rarkins rarkins added this pull request to the merge queue Jan 30, 2025
Merged via the queue into renovatebot:main with commit 545bf31 Jan 30, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.145.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants