Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git): cloneSubmodulesFilter #33115

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Dec 15, 2024

Changes

Adds new option cloneSubmodulesFilter to allow selective cloning of submodules.

Context

#33027

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice December 15, 2024 07:25
@rarkins
Copy link
Collaborator Author

rarkins commented Dec 15, 2024

Needs testing on at least one real repo

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 15, 2024

I thought about converting cloneSubmodules from boolean to string list but decided it was too complex/risky. e.g. also need to change CLI, env, etc.

lib/config/options/index.ts Show resolved Hide resolved
lib/util/git/index.ts Outdated Show resolved Hide resolved
lib/util/git/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice December 18, 2024 09:33
@rarkins rarkins enabled auto-merge December 18, 2024 09:47
@rarkins rarkins added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit e27fe66 Dec 18, 2024
39 checks passed
@rarkins rarkins deleted the feat/33027-clone-submodules-filter branch December 18, 2024 13:09
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.73.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants