Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git submodule filters #33157

Closed
rarkins opened this issue Dec 17, 2024 Discussed in #33027 · 6 comments
Closed

Support git submodule filters #33157

rarkins opened this issue Dec 17, 2024 Discussed in #33027 · 6 comments
Assignees
Labels
core:git Related to our git platform layer priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Dec 17, 2024

Discussed in #33027

Originally posted by Kobzol December 10, 2024

Tell us more.

Hi! I'm a member of the Rust infra team, and I'd like to get renovatebot working on the https://github.com/rust-lang/rust repository, which hosts the Rust toolchain (compiler, standard library etc.), using the Forking Renovatebot GitHub app.

Currently, I'm facing two blockers:

  • We need to use nightly cargo (this is already tracked in Use cargo nightly #15728 and other issues)
  • Slow speed of git submodules checkout

For updating certain Rust lockfiles, we need to checkout submodules in the Rust repository. However, the repo has a lot of submodules, some of which are very large (e.g. LLVM or GCC). I tried to set "cloneSubmodules": true, but then the renovatebot job times out after thirty minutes.

I wonder if it would be possible to either:

  • Allow selecting which submodules will be checked out. We actually need only a few small-ish submodules for the lockfile updates, but currently Renovatebot either checks out all submodules or none.
  • Make submodule checkouts faster, by using some git magic. For example, in the Rust repo, we have a custom script that makes the checkouts faster by downloading archives from GitHub (although this is not a general solution, of course).

Thanks!

@rarkins rarkins added type:feature Feature (new functionality) priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation core:git Related to our git platform layer labels Dec 17, 2024
@rarkins rarkins self-assigned this Dec 17, 2024
@rarkins
Copy link
Collaborator Author

rarkins commented Dec 17, 2024

FYI @Kobzol

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 20, 2024

Closed by #33115

Waiting for the next update of the Mend app and it will be available

@rarkins rarkins closed this as completed Dec 20, 2024
@Kobzol
Copy link

Kobzol commented Dec 22, 2024

Thank you for implementing this! Is there a way to find out what version is currently deployed in the Mend Renovate GitHub app? I haven't found it anywhere, and it doesn't seem to be deployed yet:
image

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 22, 2024

See https://docs.renovatebot.com/mend-hosted/hosted-apps-config/#renovate-version

@Kobzol
Copy link

Kobzol commented Dec 22, 2024

Thanks! I tried to search for it in the log, but it was a bit later than I expected.

@Kobzol
Copy link

Kobzol commented Dec 29, 2024

I can confirm that this works and it has helped unblock Renovatebot submodule support in rust-lang/rust 🎉 Thank you very much! Now only the nightly Cargo issue remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:git Related to our git platform layer priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants