Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): Trigger cacache to remove expired contents #28275

Merged
merged 8 commits into from
Apr 9, 2024
Merged

fix(cache): Trigger cacache to remove expired contents #28275

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
59a34a9
fix(cache): Trigger cacache to remove expired contents
gg-kialo Apr 8, 2024
ebbfb59
Update lib/util/cache/package/file.ts
gg-kialo Apr 9, 2024
77a9568
Update lib/util/cache/package/file.ts
viceice Apr 9, 2024
15e82e0
Update lib/util/cache/package/file.ts
viceice Apr 9, 2024
75325bb
Merge branch 'main' into fix/28169-clear-cacache
viceice Apr 9, 2024
1acb704
Merge branch 'main' into fix/28169-clear-cacache
rarkins Apr 9, 2024
213dbbc
Merge branch 'main' into fix/28169-clear-cacache
viceice Apr 9, 2024
592728c
Merge branch 'main' into fix/28169-clear-cacache
viceice Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/util/cache/package/file.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ describe('util/cache/package/file', () => {
await set('_test-namespace', 'valid', 1234);
await set('_test-namespace', 'expired', 1234, -5);
await cacache.put(cacheFileName, 'invalid', 'not json');
const expiredDigest = (
await cacache.get(cacheFileName, '_test-namespace-expired')
).integrity;
await cleanup();
const entries = await cacache.ls(cacheFileName);
expect(Object.keys(entries)).toEqual(['_test-namespace-valid']);
await expect(
cacache.get.byDigest(cacheFileName, expiredDigest),
).rejects.toThrow('ENOENT');
});
});
1 change: 1 addition & 0 deletions lib/util/cache/package/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export async function cleanup(): Promise<void> {
deletedCount += 1;
}
}
await cacache.verify(cacheFileName);
gg-kialo marked this conversation as resolved.
Show resolved Hide resolved
const durationMs = Math.round(Date.now() - startTime);
logger.debug(
`Deleted ${deletedCount} of ${totalCount} file cached entries in ${durationMs}ms`,
Expand Down
Loading